Re: [Qemu-block] [PATCH 17/17] checkpatch: Warn when errp is passed to error_append_hint()

2019-09-17 Thread Greg Kurz
On Tue, 17 Sep 2019 13:29:36 +0200 Cornelia Huck wrote: > On Tue, 17 Sep 2019 12:22:18 +0200 > Greg Kurz wrote: > > > Passing errp from the argument list to error_append_hint() > > isn't recommended because it may cause unwanted behaviours > > when errp is equal to &error_fatal or &error_abort.

Re: [Qemu-block] [PATCH 17/17] checkpatch: Warn when errp is passed to error_append_hint()

2019-09-17 Thread Cornelia Huck
On Tue, 17 Sep 2019 12:22:18 +0200 Greg Kurz wrote: > Passing errp from the argument list to error_append_hint() > isn't recommended because it may cause unwanted behaviours > when errp is equal to &error_fatal or &error_abort. > > First, error_append_hint() aborts QEMU when passed either of > t