Re: [Qemu-block] [PATCH 2/2] qapi: Allow blockdev-add for NBD

2016-02-04 Thread Paolo Bonzini
On 03/02/2016 17:48, Eric Blake wrote: > On 02/03/2016 09:33 AM, Max Reitz wrote: >> We have to introduce a new object (BlockdevOptionsNbd) for >> several reasons: - Neither of InetSocketAddress nor >> UnixSocketAddress alone is sufficient, because both are >> supported - We cannot use

Re: [Qemu-block] [PATCH 2/2] qapi: Allow blockdev-add for NBD

2016-02-03 Thread Eric Blake
On 02/03/2016 09:33 AM, Max Reitz wrote: > We have to introduce a new object (BlockdevOptionsNbd) for several > reasons: > - Neither of InetSocketAddress nor UnixSocketAddress alone is > sufficient, because both are supported > - We cannot use SocketAddress because NBD does not support an fd, >

[Qemu-block] [PATCH 2/2] qapi: Allow blockdev-add for NBD

2016-02-03 Thread Max Reitz
We have to introduce a new object (BlockdevOptionsNbd) for several reasons: - Neither of InetSocketAddress nor UnixSocketAddress alone is sufficient, because both are supported - We cannot use SocketAddress because NBD does not support an fd, and because it is not a flat union which

Re: [Qemu-block] [PATCH 2/2] qapi: Allow blockdev-add for NBD

2016-02-03 Thread Max Reitz
On 03.02.2016 17:48, Eric Blake wrote: > On 02/03/2016 09:33 AM, Max Reitz wrote: >> We have to introduce a new object (BlockdevOptionsNbd) for several >> reasons: >> - Neither of InetSocketAddress nor UnixSocketAddress alone is >> sufficient, because both are supported >> - We cannot use