Re: [Qemu-block] [PATCH 2/2] qobject: modify qobject_ref() to assert on NULL

On Fri 17 Aug 2018 07:19:32 PM CEST, Marc-André Lureau wrote: > diff --git a/block/quorum.c b/block/quorum.c > index 9152da8c58..96cd094ede 100644 > --- a/block/quorum.c > +++ b/block/quorum.c > @@ -1089,7 +1089,8 @@ static void quorum_refresh_filename(BlockDriverState > *bs, QDict *options) >

[Qemu-block] [PATCH 2/2] qobject: modify qobject_ref() to assert on NULL

While it may be convenient to accept NULL value in qobject_unref() (for similar reasons as free() accepts NULL), it is not such a good idea for qobject_ref(): now assert() on NULL. Some code relied on that behaviour, but it's best to be explicit that NULL is accepted. We have to rely on testing,