Re: [Qemu-block] [PATCH 2/3] ide: ignore retry_unit check for non-retry operations

2016-06-29 Thread Paolo Bonzini
On 29/06/2016 10:35, Evgeny Yakovlev wrote: >>> >> Wouldn't the assertion fail for a PIO read/write too? Perhaps >> retry_unit should be set to s->unit in ide_transfer_start too. > > If PIO follows DMA and fails then yes, it looks like it will trigger an > assert. I am not sure about setting

Re: [Qemu-block] [PATCH 2/3] ide: ignore retry_unit check for non-retry operations

2016-06-29 Thread Evgeny Yakovlev
On 28.06.2016 23:56, Paolo Bonzini wrote: On 24/06/2016 17:06, Denis V. Lunev wrote: When doing DMA request ide/core.c will set s->retry_unit to s->unit in ide_start_dma. When dma completes ide_set_inactive sets retry_unit to -1. After that ide_flush_cache runs and fails thanks to blkdebug.

Re: [Qemu-block] [PATCH 2/3] ide: ignore retry_unit check for non-retry operations

2016-06-28 Thread Paolo Bonzini
On 24/06/2016 17:06, Denis V. Lunev wrote: > When doing DMA request ide/core.c will set s->retry_unit to s->unit in > ide_start_dma. When dma completes ide_set_inactive sets retry_unit to -1. > After that ide_flush_cache runs and fails thanks to blkdebug. > ide_flush_cb calls ide_handle_rw_error

[Qemu-block] [PATCH 2/3] ide: ignore retry_unit check for non-retry operations

2016-06-24 Thread Denis V. Lunev
From: Evgeny Yakovlev The following sequence of tests discovered a problem in IDE emulation: 1. Send DMA write to IDE device 0 2. Send CMD_FLUSH_CACHE to same IDE device which will be failed by block layer using blkdebug script in tests/ide-test:test_retry_flush When