Re: [Qemu-block] [PATCH 2/5] block: Don't try to set *errp directly

2017-06-08 Thread Alberto Garcia
On Thu 08 Jun 2017 03:39:03 PM CEST, Eduardo Habkost wrote: > Assigning directly to *errp is not valid, as errp may be NULL, > _fatal, or _abort. Use error_propagate() instead. Well, the NULL case was already handled by the code, but _fatal and _abort certainly not. > With this, there's no need

[Qemu-block] [PATCH 2/5] block: Don't try to set *errp directly

2017-06-08 Thread Eduardo Habkost
Assigning directly to *errp is not valid, as errp may be NULL, _fatal, or _abort. Use error_propagate() instead. With this, there's no need to check if errp is NULL anymore, as error_propagate() and error_prepend() are able to handle that. Cc: Kevin Wolf Cc: Max Reitz