Re: [Qemu-block] [PATCH 3/4] block/parallels: Don't update header until the first actual write

2017-10-29 Thread Kevin Wolf
Am 27.10.2017 um 12:18 hat Jeff Cody geschrieben: > On Fri, Oct 27, 2017 at 11:09:19AM +0200, Kevin Wolf wrote: > > Am 27.10.2017 um 10:57 hat Jeff Cody geschrieben: > > > The on disk image format 'inuse' header field is updated blindly if the > > > image is opened RDWR. This can cause problems

Re: [Qemu-block] [PATCH 3/4] block/parallels: Don't update header until the first actual write

2017-10-27 Thread Denis V. Lunev
On 10/27/2017 10:57 AM, Jeff Cody wrote: > The on disk image format 'inuse' header field is updated blindly if the > image is opened RDWR. This can cause problems if the QEMU runstate is > set to INMIGRATE, at which point the underlying file is set to INACTIVE. > This causes an assert in

Re: [Qemu-block] [PATCH 3/4] block/parallels: Don't update header until the first actual write

2017-10-27 Thread Jeff Cody
On Fri, Oct 27, 2017 at 11:09:19AM +0200, Kevin Wolf wrote: > Am 27.10.2017 um 10:57 hat Jeff Cody geschrieben: > > The on disk image format 'inuse' header field is updated blindly if the > > image is opened RDWR. This can cause problems if the QEMU runstate is > > set to INMIGRATE, at which

Re: [Qemu-block] [PATCH 3/4] block/parallels: Don't update header until the first actual write

2017-10-27 Thread Kevin Wolf
Am 27.10.2017 um 10:57 hat Jeff Cody geschrieben: > The on disk image format 'inuse' header field is updated blindly if the > image is opened RDWR. This can cause problems if the QEMU runstate is > set to INMIGRATE, at which point the underlying file is set to INACTIVE. > This causes an assert in

[Qemu-block] [PATCH 3/4] block/parallels: Don't update header until the first actual write

2017-10-27 Thread Jeff Cody
The on disk image format 'inuse' header field is updated blindly if the image is opened RDWR. This can cause problems if the QEMU runstate is set to INMIGRATE, at which point the underlying file is set to INACTIVE. This causes an assert in bdrv_co_pwritev(). Do something similar to what is done