Re: [Qemu-block] [PATCH 5/6] tests: add iotests helpers for dealing with TLS certificates

2018-11-19 Thread Daniel P . Berrangé
On Mon, Nov 19, 2018 at 08:27:56AM -0600, Eric Blake wrote: > On 11/19/18 5:04 AM, Max Reitz wrote: > > > > > > +tls_dir="${TEST_DIR}/tls" > > > > > + > > > > > +function tls_x509_cleanup() > > > > > +{ > > > > > +rm -f ${tls_dir}/*.pem > > > > > +rm -f ${tls_dir}/*/*.pem > > > > > +

Re: [Qemu-block] [PATCH 5/6] tests: add iotests helpers for dealing with TLS certificates

2018-11-19 Thread Eric Blake
On 11/19/18 5:04 AM, Max Reitz wrote: +tls_dir="${TEST_DIR}/tls" + +function tls_x509_cleanup() +{ +rm -f ${tls_dir}/*.pem +rm -f ${tls_dir}/*/*.pem +rmdir ${tls_dir}/* +rmdir ${tls_dir} Why not just: rm -rf $tls_dir Yeah, I guess we could do that for simplicity Also, the

Re: [Qemu-block] [PATCH 5/6] tests: add iotests helpers for dealing with TLS certificates

2018-11-19 Thread Max Reitz
On 19.11.18 11:27, Daniel P. Berrangé wrote: > On Fri, Nov 16, 2018 at 10:39:03AM -0600, Eric Blake wrote: >> On 11/16/18 9:53 AM, Daniel P. Berrangé wrote: >>> Add helpers to common.tls for creating TLS certificates for a CA, >>> server and client. >> >> MUCH appreciated! We NEED this coverage,

Re: [Qemu-block] [PATCH 5/6] tests: add iotests helpers for dealing with TLS certificates

2018-11-19 Thread Daniel P . Berrangé
On Fri, Nov 16, 2018 at 10:39:03AM -0600, Eric Blake wrote: > On 11/16/18 9:53 AM, Daniel P. Berrangé wrote: > > Add helpers to common.tls for creating TLS certificates for a CA, > > server and client. > > MUCH appreciated! We NEED this coverage, easily automated. > > > > > Signed-off-by:

Re: [Qemu-block] [PATCH 5/6] tests: add iotests helpers for dealing with TLS certificates

2018-11-16 Thread Eric Blake
On 11/16/18 9:53 AM, Daniel P. Berrangé wrote: Add helpers to common.tls for creating TLS certificates for a CA, server and client. MUCH appreciated! We NEED this coverage, easily automated. Signed-off-by: Daniel P. Berrangé --- tests/qemu-iotests/common.tls | 139

[Qemu-block] [PATCH 5/6] tests: add iotests helpers for dealing with TLS certificates

2018-11-16 Thread Daniel P . Berrangé
Add helpers to common.tls for creating TLS certificates for a CA, server and client. Signed-off-by: Daniel P. Berrangé --- tests/qemu-iotests/common.tls | 139 ++ 1 file changed, 139 insertions(+) create mode 100644 tests/qemu-iotests/common.tls diff --git