On Tue 06 Nov 2018 05:24:36 PM CET, Vladimir Sementsov-Ogievskiy wrote:
>> Is there any reason why some parts of the QEMU code use qemu_blockalign
>> and others qemu_try_blockalign() ? From what I can see it seems to be up
>> to whoever wrote it...
>
> As I understand, the good reason to use _try_
06.11.2018 18:30, Alberto Garcia wrote:
> On Tue 06 Nov 2018 04:13:58 PM CET, Vladimir Sementsov-Ogievskiy wrote:
>> 06.11.2018 18:06, Alberto Garcia wrote:
>>> On Thu 01 Nov 2018 07:27:37 PM CET, Vladimir Sementsov-Ogievskiy wrote:
>>>
+buf = g_try_malloc(csize);
+if (!buf) {
On Tue 06 Nov 2018 04:13:58 PM CET, Vladimir Sementsov-Ogievskiy wrote:
> 06.11.2018 18:06, Alberto Garcia wrote:
>> On Thu 01 Nov 2018 07:27:37 PM CET, Vladimir Sementsov-Ogievskiy wrote:
>>
>>> +buf = g_try_malloc(csize);
>>> +if (!buf) {
>>> +return -ENOMEM;
>>> +}
>>> +
06.11.2018 18:06, Alberto Garcia wrote:
> On Thu 01 Nov 2018 07:27:37 PM CET, Vladimir Sementsov-Ogievskiy wrote:
>
>> +buf = g_try_malloc(csize);
>> +if (!buf) {
>> +return -ENOMEM;
>> +}
>> +iov.iov_base = buf;
>> +iov.iov_len = csize;
>> +
On Thu 01 Nov 2018 07:27:37 PM CET, Vladimir Sementsov-Ogievskiy wrote:
> +buf = g_try_malloc(csize);
> +if (!buf) {
> +return -ENOMEM;
> +}
> +iov.iov_base = buf;
> +iov.iov_len = csize;
> +qemu_iovec_init_external(_qiov, , 1);
>
> -iov.iov_base =
Allocate buffers locally and release qcow2 lock. Than, reads inside
qcow2_co_preadv_compressed may be done in parallel, however all
decompression is still done synchronously. Let's improve it in the
following commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2.h | 4 ---
