Re: [Qemu-block] [PATCH for-2.10 1/5] block: Fix order in bdrv_replace_child()

2017-08-03 Thread Jeff Cody
On Thu, Aug 03, 2017 at 05:02:57PM +0200, Kevin Wolf wrote: > Commit 8ee03995 refactored the code incorrectly and broke the release of > permissions on the old BDS. Instead of changing the permissions to the > new required values after removing the old BDS from the list of > children, it only re-ob

[Qemu-block] [PATCH for-2.10 1/5] block: Fix order in bdrv_replace_child()

2017-08-03 Thread Kevin Wolf
Commit 8ee03995 refactored the code incorrectly and broke the release of permissions on the old BDS. Instead of changing the permissions to the new required values after removing the old BDS from the list of children, it only re-obtains the permissions it already had. Change the order of operation