Re: [Qemu-block] [PATCH for-2.4] block: keep bitmap if incremental backup job is cancelled

2015-06-26 Thread Stefan Hajnoczi
On Thu, Jun 25, 2015 at 12:33:25PM -0400, Jeff Cody wrote: On Thu, Jun 25, 2015 at 12:30:56PM -0400, John Snow wrote: On 06/25/2015 08:53 AM, Stefan Hajnoczi wrote: Reclaim the dirty bitmap if an incremental backup block job is cancelled. The ret variable may be 0 when the job is

Re: [Qemu-block] [PATCH for-2.4] block: keep bitmap if incremental backup job is cancelled

2015-06-26 Thread Max Reitz
On 26.06.2015 11:57, Stefan Hajnoczi wrote: On Thu, Jun 25, 2015 at 12:33:25PM -0400, Jeff Cody wrote: On Thu, Jun 25, 2015 at 12:30:56PM -0400, John Snow wrote: On 06/25/2015 08:53 AM, Stefan Hajnoczi wrote: Reclaim the dirty bitmap if an incremental backup block job is cancelled. The ret

[Qemu-block] [PATCH for-2.4] block: keep bitmap if incremental backup job is cancelled

2015-06-25 Thread Stefan Hajnoczi
Reclaim the dirty bitmap if an incremental backup block job is cancelled. The ret variable may be 0 when the job is cancelled so it's not enough to check ret 0. Reviewed-by: John Snow js...@redhat.com Reviewed-by: Max Reitz mre...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com

Re: [Qemu-block] [PATCH for-2.4] block: keep bitmap if incremental backup job is cancelled

2015-06-25 Thread Jeff Cody
On Thu, Jun 25, 2015 at 12:30:56PM -0400, John Snow wrote: On 06/25/2015 08:53 AM, Stefan Hajnoczi wrote: Reclaim the dirty bitmap if an incremental backup block job is cancelled. The ret variable may be 0 when the job is cancelled so it's not enough to check ret 0. Reviewed-by:

Re: [Qemu-block] [PATCH for-2.4] block: keep bitmap if incremental backup job is cancelled

2015-06-25 Thread John Snow
On 06/25/2015 08:53 AM, Stefan Hajnoczi wrote: Reclaim the dirty bitmap if an incremental backup block job is cancelled. The ret variable may be 0 when the job is cancelled so it's not enough to check ret 0. Reviewed-by: John Snow js...@redhat.com Reviewed-by: Max Reitz