Re: [Qemu-block] [PATCH v2 00/13] Dirty bitmap changes for migration/persistence work

2016-01-21 Thread Fam Zheng
On Thu, 01/21 13:41, Vladimir Sementsov-Ogievskiy wrote: > An idea/question. > > What about make some const dirty bitmap finctions really const? > > bdrv_dirty_bitmap_name(BdrvDirtyBitmap *bitmap) -> > bdrv_dirty_bitmap_name(const BdrvDirtyBitmap *bitmap) >

Re: [Qemu-block] [PATCH v2 00/13] Dirty bitmap changes for migration/persistence work

2016-01-21 Thread Vladimir Sementsov-Ogievskiy
An idea/question. What about make some const dirty bitmap finctions really const? bdrv_dirty_bitmap_name(BdrvDirtyBitmap *bitmap) -> bdrv_dirty_bitmap_name(const BdrvDirtyBitmap *bitmap) bdrv_dirty_bitmap_size(BdrvDirtyBitmap *bitmap) -> bdrv_dirty_bitmap_size(const BdrvDirtyBitmap

[Qemu-block] [PATCH v2 00/13] Dirty bitmap changes for migration/persistence work

2016-01-19 Thread Fam Zheng
v2: Various changes addressing John's and Vladimir's comments: [02/13] typedefs: Add BdrvDirtyBitmap Skip HBitmapIter because we'll hide it soon. [John] [03/13] block: Move block dirty bitmap code to separate files [04/13] block: Remove unused typedef of