Re: [Qemu-block] [PATCH v2 02/18] drive-backup: create do_backup_common

2019-07-05 Thread John Snow
On 7/4/19 11:06 AM, Max Reitz wrote: > On 03.07.19 23:55, John Snow wrote: >> Create a common core that comprises the actual meat of what the backup API >> boundary needs to do, and then switch drive-backup to use it. >> >> Questions: >> - do_drive_backup now acquires and releases the

Re: [Qemu-block] [PATCH v2 02/18] drive-backup: create do_backup_common

2019-07-05 Thread John Snow
On 7/4/19 11:06 AM, Max Reitz wrote: > On 03.07.19 23:55, John Snow wrote: >> Create a common core that comprises the actual meat of what the backup API >> boundary needs to do, and then switch drive-backup to use it. >> >> Questions: >> - do_drive_backup now acquires and releases the

Re: [Qemu-block] [PATCH v2 02/18] drive-backup: create do_backup_common

2019-07-04 Thread Max Reitz
On 03.07.19 23:55, John Snow wrote: > Create a common core that comprises the actual meat of what the backup API > boundary needs to do, and then switch drive-backup to use it. > > Questions: > - do_drive_backup now acquires and releases the aio_context in addition >to do_backup_common doing

[Qemu-block] [PATCH v2 02/18] drive-backup: create do_backup_common

2019-07-03 Thread John Snow
Create a common core that comprises the actual meat of what the backup API boundary needs to do, and then switch drive-backup to use it. Questions: - do_drive_backup now acquires and releases the aio_context in addition to do_backup_common doing the same. Can I drop this from drive_backup?