[Qemu-block] [PATCH v2 5/6] iotests: implement QemuIoInteractive class

2018-01-18 Thread Vladimir Sementsov-Ogievskiy
Implement QemuIoInteractive to test nbd-server-remove command when there are active connections. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 38 ++ 1 file changed, 38 insertions(+) diff --git a/tests/qemu-iotests/iotests.py

Re: [Qemu-block] [PATCH v2 5/6] iotests: implement QemuIoInteractive class

2018-01-12 Thread Eric Blake
On 01/12/2018 05:56 AM, Vladimir Sementsov-Ogievskiy wrote: >> My python is not strong; it looks good overall, although I have a few >> questions that may warrant a v3 before I give R-b. >> >>> +class QemuIoInteractive: >>> +    def __init__(self, *args): >>> +    self.args = qemu_io_args + li

Re: [Qemu-block] [PATCH v2 5/6] iotests: implement QemuIoInteractive class

2018-01-12 Thread Vladimir Sementsov-Ogievskiy
09.01.2018 23:34, Eric Blake wrote: On 12/07/2017 09:51 AM, Vladimir Sementsov-Ogievskiy wrote: The subject says what, but there is no commit body that says why. Presumably this makes writing the test in the next patch easier, but some details in the commit message would make this obvious. Si

Re: [Qemu-block] [PATCH v2 5/6] iotests: implement QemuIoInteractive class

2018-01-09 Thread Eric Blake
On 12/07/2017 09:51 AM, Vladimir Sementsov-Ogievskiy wrote: The subject says what, but there is no commit body that says why. Presumably this makes writing the test in the next patch easier, but some details in the commit message would make this obvious. > Signed-off-by: Vladimir Sementsov-Ogiev

[Qemu-block] [PATCH v2 5/6] iotests: implement QemuIoInteractive class

2017-12-07 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 38 ++ 1 file changed, 38 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 6f057904a9..a9f312db83 100644 --- a/tests/qemu-iotests/iote