Re: [Qemu-block] [PATCH v2 5/7] virtio-blk: Call virtio_add_queue_aio

2016-06-28 Thread Paolo Bonzini
On 28/06/2016 17:12, Stefan Hajnoczi wrote:\ > It's weird that virtio_add_queue_aio() doesn't take an AioContext. > > This change moves us one step closer to dropping dataplane-specific > code. The difference between dataplane and non-dataplane should simply > by the virtqueue's AioContext,

Re: [Qemu-block] [PATCH v2 5/7] virtio-blk: Call virtio_add_queue_aio

2016-06-28 Thread Stefan Hajnoczi
On Fri, Jun 24, 2016 at 08:39:32PM +0800, Fam Zheng wrote: > AIO based handler is more appropriate here because it will then > cooperate with bdrv_drained_begin/end. It is needed by the coming > revert patch. > > Signed-off-by: Fam Zheng > --- > hw/block/virtio-blk.c | 2 +- >

[Qemu-block] [PATCH v2 5/7] virtio-blk: Call virtio_add_queue_aio

2016-06-24 Thread Fam Zheng
AIO based handler is more appropriate here because it will then cooperate with bdrv_drained_begin/end. It is needed by the coming revert patch. Signed-off-by: Fam Zheng --- hw/block/virtio-blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git