Re: [Qemu-block] [PATCH v3] block/rbd: implement .bdrv_get_allocated_file_size callback

2019-07-10 Thread Stefano Garzarella
On Tue, Jul 09, 2019 at 09:42:14PM -0400, Jason Dillaman wrote: > On Tue, Jul 9, 2019 at 11:32 AM Max Reitz wrote: > > On 09.07.19 15:09, Stefano Garzarella wrote: > > > > > > Max, Jason, thanks for the details! > > > > > > If you agree, I'll try to implement something similar, iterating on all >

Re: [Qemu-block] [PATCH v3] block/rbd: implement .bdrv_get_allocated_file_size callback

2019-07-09 Thread Jason Dillaman
On Tue, Jul 9, 2019 at 11:32 AM Max Reitz wrote: > > On 09.07.19 15:09, Stefano Garzarella wrote: > > On Tue, Jul 09, 2019 at 08:55:19AM -0400, Jason Dillaman wrote: > >> On Tue, Jul 9, 2019 at 5:45 AM Max Reitz wrote: > >>> > >>> On 09.07.19 10:55, Max Reitz wrote: > On 09.07.19 05:08,

Re: [Qemu-block] [PATCH v3] block/rbd: implement .bdrv_get_allocated_file_size callback

2019-07-09 Thread Max Reitz
On 09.07.19 15:09, Stefano Garzarella wrote: > On Tue, Jul 09, 2019 at 08:55:19AM -0400, Jason Dillaman wrote: >> On Tue, Jul 9, 2019 at 5:45 AM Max Reitz wrote: >>> >>> On 09.07.19 10:55, Max Reitz wrote: On 09.07.19 05:08, Jason Dillaman wrote: > On Fri, Jul 5, 2019 at 6:43 AM Stefano

Re: [Qemu-block] [PATCH v3] block/rbd: implement .bdrv_get_allocated_file_size callback

2019-07-09 Thread Stefano Garzarella
On Tue, Jul 09, 2019 at 08:55:19AM -0400, Jason Dillaman wrote: > On Tue, Jul 9, 2019 at 5:45 AM Max Reitz wrote: > > > > On 09.07.19 10:55, Max Reitz wrote: > > > On 09.07.19 05:08, Jason Dillaman wrote: > > >> On Fri, Jul 5, 2019 at 6:43 AM Stefano Garzarella > > >> wrote: > > >>> > > >>> On

Re: [Qemu-block] [PATCH v3] block/rbd: implement .bdrv_get_allocated_file_size callback

2019-07-09 Thread Jason Dillaman
On Tue, Jul 9, 2019 at 5:45 AM Max Reitz wrote: > > On 09.07.19 10:55, Max Reitz wrote: > > On 09.07.19 05:08, Jason Dillaman wrote: > >> On Fri, Jul 5, 2019 at 6:43 AM Stefano Garzarella > >> wrote: > >>> > >>> On Fri, Jul 05, 2019 at 11:58:43AM +0200, Max Reitz wrote: > On 05.07.19

Re: [Qemu-block] [PATCH v3] block/rbd: implement .bdrv_get_allocated_file_size callback

2019-07-09 Thread Max Reitz
On 09.07.19 10:55, Max Reitz wrote: > On 09.07.19 05:08, Jason Dillaman wrote: >> On Fri, Jul 5, 2019 at 6:43 AM Stefano Garzarella >> wrote: >>> >>> On Fri, Jul 05, 2019 at 11:58:43AM +0200, Max Reitz wrote: On 05.07.19 11:32, Stefano Garzarella wrote: > This patch allows 'qemu-img

Re: [Qemu-block] [PATCH v3] block/rbd: implement .bdrv_get_allocated_file_size callback

2019-07-09 Thread Max Reitz
On 09.07.19 05:08, Jason Dillaman wrote: > On Fri, Jul 5, 2019 at 6:43 AM Stefano Garzarella wrote: >> >> On Fri, Jul 05, 2019 at 11:58:43AM +0200, Max Reitz wrote: >>> On 05.07.19 11:32, Stefano Garzarella wrote: This patch allows 'qemu-img info' to show the 'disk size' for the RBD

Re: [Qemu-block] [PATCH v3] block/rbd: implement .bdrv_get_allocated_file_size callback

2019-07-08 Thread Jason Dillaman
On Fri, Jul 5, 2019 at 6:43 AM Stefano Garzarella wrote: > > On Fri, Jul 05, 2019 at 11:58:43AM +0200, Max Reitz wrote: > > On 05.07.19 11:32, Stefano Garzarella wrote: > > > This patch allows 'qemu-img info' to show the 'disk size' for > > > the RBD images that have the fast-diff feature

Re: [Qemu-block] [PATCH v3] block/rbd: implement .bdrv_get_allocated_file_size callback

2019-07-05 Thread Stefano Garzarella
On Fri, Jul 05, 2019 at 11:58:43AM +0200, Max Reitz wrote: > On 05.07.19 11:32, Stefano Garzarella wrote: > > This patch allows 'qemu-img info' to show the 'disk size' for > > the RBD images that have the fast-diff feature enabled. > > > > If this feature is enabled, we use the

Re: [Qemu-block] [PATCH v3] block/rbd: implement .bdrv_get_allocated_file_size callback

2019-07-05 Thread Max Reitz
On 05.07.19 11:32, Stefano Garzarella wrote: > This patch allows 'qemu-img info' to show the 'disk size' for > the RBD images that have the fast-diff feature enabled. > > If this feature is enabled, we use the rbd_diff_iterate2() API > to calculate the allocated size for the image. > >