Re: [Qemu-block] [PATCH v3] block: mirror - fix full sync mode when target does not support zero init

2015-10-01 Thread Jeff Cody
On Thu, Oct 01, 2015 at 03:35:15PM +0200, Paolo Bonzini wrote: > > > On 01/10/2015 15:14, Jeff Cody wrote: > > During mirror, if the target device does not support zero init, a > > mirror may result in a corrupted image for sync="full" mode. > > > > This is due to how the initial dirty bitmap

[Qemu-block] [PATCH v3] block: mirror - fix full sync mode when target does not support zero init

2015-10-01 Thread Jeff Cody
During mirror, if the target device does not support zero init, a mirror may result in a corrupted image for sync="full" mode. This is due to how the initial dirty bitmap is set up prior to copying data - we did not mark sectors as dirty that are unallocated. This means those unallocated sectors

Re: [Qemu-block] [PATCH v3] block: mirror - fix full sync mode when target does not support zero init

2015-10-01 Thread Paolo Bonzini
On 01/10/2015 15:14, Jeff Cody wrote: > During mirror, if the target device does not support zero init, a > mirror may result in a corrupted image for sync="full" mode. > > This is due to how the initial dirty bitmap is set up prior to copying > data - we did not mark sectors as dirty that are

Re: [Qemu-block] [PATCH v3] block: mirror - fix full sync mode when target does not support zero init

2015-10-01 Thread Jeff Cody
On Thu, Oct 01, 2015 at 09:14:51AM -0400, Jeff Cody wrote: > During mirror, if the target device does not support zero init, a > mirror may result in a corrupted image for sync="full" mode. > > This is due to how the initial dirty bitmap is set up prior to copying > data - we did not mark sectors