Re: [Qemu-block] [PATCH v3 04/13] nbd: convert to using I/O channels for actual socket I/O

2016-01-19 Thread Paolo Bonzini
On 19/01/2016 17:52, Daniel P. Berrange wrote: > I'll have a look at this and see what I can do. It shouldn't block > merging of this patch I assume, since the current call to > qemu_coroutine_yield() should be fine - it just my comment suggestion > that would not work. Yes, that is tied to

[Qemu-block] [PATCH v3 04/13] nbd: convert to using I/O channels for actual socket I/O

2016-01-19 Thread Daniel P. Berrange
Now that all callers are converted to use I/O channels for initial connection setup, it is possible to switch the core NBD protocol handling core over to use QIOChannel APIs for actual sockets I/O. Signed-off-by: Daniel P. Berrange --- block/nbd-client.c | 19 +++

Re: [Qemu-block] [PATCH v3 04/13] nbd: convert to using I/O channels for actual socket I/O

2016-01-19 Thread Daniel P. Berrange
On Tue, Jan 19, 2016 at 05:08:12PM +0100, Paolo Bonzini wrote: > > > On 19/01/2016 14:09, Daniel P. Berrange wrote: > > + * This will update @iov so that its head is advanced > > + * by @skip bytes. To do this, zero or more complete > > + * elements of @iov will be skipped over. The new head > >