Re: [Qemu-block] [PATCH v3 07/33] automatically add vmstate for reset support in devices

2019-08-09 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Thu, 8 Aug 2019 at 16:42, Dr. David Alan Gilbert > wrote: > > > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > > On Mon, 29 Jul 2019 at 15:59, Damien Hedde > > > wrote: > > > > > > > > This add the reset related sections for every

Re: [Qemu-block] [PATCH v3 07/33] automatically add vmstate for reset support in devices

2019-08-09 Thread Juan Quintela
Damien Hedde wrote: > On 8/9/19 12:32 PM, Peter Maydell wrote: >> On Fri, 9 Aug 2019 at 11:29, Damien Hedde wrote: >>> >>> One way to keep the feature without copy-pasting vmsd would be to add >>> a new vmstate_register with an additional argument to pass the base >>> class vmsd section and

Re: [Qemu-block] [PATCH v3 07/33] automatically add vmstate for reset support in devices

2019-08-09 Thread Juan Quintela
Peter Maydell wrote: > On Fri, 9 Aug 2019 at 11:29, Damien Hedde wrote: >> >> One way to keep the feature without copy-pasting vmsd would be to add >> a new vmstate_register with an additional argument to pass the base >> class vmsd section and handle the whole thing there. > > If we have a

Re: [Qemu-block] [PATCH v3 07/33] automatically add vmstate for reset support in devices

2019-08-09 Thread Damien Hedde
On 8/9/19 12:32 PM, Peter Maydell wrote: > On Fri, 9 Aug 2019 at 11:29, Damien Hedde wrote: >> >> One way to keep the feature without copy-pasting vmsd would be to add >> a new vmstate_register with an additional argument to pass the base >> class vmsd section and handle the whole thing there.

Re: [Qemu-block] [PATCH v3 07/33] automatically add vmstate for reset support in devices

2019-08-09 Thread Peter Maydell
On Fri, 9 Aug 2019 at 11:29, Damien Hedde wrote: > > One way to keep the feature without copy-pasting vmsd would be to add > a new vmstate_register with an additional argument to pass the base > class vmsd section and handle the whole thing there. If we have a vmstate section which contains no

Re: [Qemu-block] [PATCH v3 07/33] automatically add vmstate for reset support in devices

2019-08-09 Thread Damien Hedde
On 8/9/19 12:07 PM, Peter Maydell wrote: > On Thu, 8 Aug 2019 at 16:42, Dr. David Alan Gilbert > wrote: >> >> * Peter Maydell (peter.mayd...@linaro.org) wrote: >>> On Mon, 29 Jul 2019 at 15:59, Damien Hedde >>> wrote: This add the reset related sections for every QOM device.

Re: [Qemu-block] [PATCH v3 07/33] automatically add vmstate for reset support in devices

2019-08-09 Thread Peter Maydell
On Thu, 8 Aug 2019 at 16:42, Dr. David Alan Gilbert wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > On Mon, 29 Jul 2019 at 15:59, Damien Hedde > > wrote: > > > > > > This add the reset related sections for every QOM > > > device. > > > > A bit more detail in the commit message

Re: [Qemu-block] [PATCH v3 07/33] automatically add vmstate for reset support in devices

2019-08-08 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Mon, 29 Jul 2019 at 15:59, Damien Hedde wrote: > > > > This add the reset related sections for every QOM > > device. > > A bit more detail in the commit message would help, I think -- > this is adding extra machinery which has to copy and

Re: [Qemu-block] [PATCH v3 07/33] automatically add vmstate for reset support in devices

2019-08-07 Thread Damien Hedde
On 8/7/19 5:07 PM, Peter Maydell wrote: > On Mon, 29 Jul 2019 at 15:59, Damien Hedde wrote: >> >> This add the reset related sections for every QOM >> device. > > A bit more detail in the commit message would help, I think -- > this is adding extra machinery which has to copy and modify > the

Re: [Qemu-block] [PATCH v3 07/33] automatically add vmstate for reset support in devices

2019-08-07 Thread Peter Maydell
On Mon, 29 Jul 2019 at 15:59, Damien Hedde wrote: > > This add the reset related sections for every QOM > device. A bit more detail in the commit message would help, I think -- this is adding extra machinery which has to copy and modify the VMStateDescription passed in by the device in order to

[Qemu-block] [PATCH v3 07/33] automatically add vmstate for reset support in devices

2019-07-29 Thread Damien Hedde
This add the reset related sections for every QOM device. Signed-off-by: Damien Hedde --- hw/core/qdev-vmstate.c | 41 + hw/core/qdev.c | 12 +++- include/hw/qdev-core.h | 3 +++ stubs/Makefile.objs| 1 + stubs/device.c | 7