Re: [Qemu-block] [PATCH v3 4/9] block/commit: utilize job_exit shim

2018-08-31 Thread Jeff Cody
On Wed, Aug 29, 2018 at 09:57:29PM -0400, John Snow wrote: > Change the manual deferment to commit_complete into the implicit > callback to job_exit, renaming commit_complete to commit_exit. > > This conversion does change the timing of when job_completed is > called to after the

[Qemu-block] [PATCH v3 4/9] block/commit: utilize job_exit shim

2018-08-29 Thread John Snow
Change the manual deferment to commit_complete into the implicit callback to job_exit, renaming commit_complete to commit_exit. This conversion does change the timing of when job_completed is called to after the bdrv_replace_node and bdrv_unref calls, which could have implications for bjob->blk