Re: [Qemu-block] [PATCH v4 02/10] raw: Check byte range uniformly

2018-05-13 Thread Fam Zheng
On Fri, 05/11 08:59, Eric Blake wrote: > On 05/11/2018 07:08 AM, Fam Zheng wrote: > > We don't verify the request range against s->size in the I/O callbacks > > except for raw_co_pwritev. This is wrong (especially for > > raw_co_pwrite_zeroes and raw_co_pdiscard), so fix them. > > Did you bother i

Re: [Qemu-block] [PATCH v4 02/10] raw: Check byte range uniformly

2018-05-11 Thread Eric Blake
On 05/11/2018 07:08 AM, Fam Zheng wrote: We don't verify the request range against s->size in the I/O callbacks except for raw_co_pwritev. This is wrong (especially for raw_co_pwrite_zeroes and raw_co_pdiscard), so fix them. Did you bother identifying how long the bug has been present (but read

[Qemu-block] [PATCH v4 02/10] raw: Check byte range uniformly

2018-05-11 Thread Fam Zheng
We don't verify the request range against s->size in the I/O callbacks except for raw_co_pwritev. This is wrong (especially for raw_co_pwrite_zeroes and raw_co_pdiscard), so fix them. Signed-off-by: Fam Zheng --- block/raw-format.c | 63 -- 1 f