Re: [Qemu-block] [PATCH v4 04/11] block: improve should_update_child

2018-11-06 Thread Kevin Wolf
Am 15.10.2018 um 18:06 hat Vladimir Sementsov-Ogievskiy geschrieben: > As it already said in the comment, we don't want to create loops in > parent->child relations. So, when we try to append @to to @c, we should > check that @c is not in @to children subtree, and we should check it > recursively,

[Qemu-block] [PATCH v4 04/11] block: improve should_update_child

2018-10-15 Thread Vladimir Sementsov-Ogievskiy
As it already said in the comment, we don't want to create loops in parent->child relations. So, when we try to append @to to @c, we should check that @c is not in @to children subtree, and we should check it recursively, not only the first level. The patch provides BFS-based search, to check the