Re: [Qemu-block] [PATCH v4 05/10] block/nbd-client: don't check ioc

2019-01-16 Thread Eric Blake
On 7/31/18 12:30 PM, Vladimir Sementsov-Ogievskiy wrote: > We have several paranoiac checks for ioc != NULL. But ioc may become s/paranoiac/paranoid/ sounds nicer, even if both forms are valid words. > NULL only on close, which should not happen during requests handling. > Also, we check ioc

[Qemu-block] [PATCH v4 05/10] block/nbd-client: don't check ioc

2018-07-31 Thread Vladimir Sementsov-Ogievskiy
We have several paranoiac checks for ioc != NULL. But ioc may become NULL only on close, which should not happen during requests handling. Also, we check ioc only sometimes, not after each yield, which is inconsistent. Let's drop these checks. However, for safety, lets leave asserts instead.