Re: [Qemu-block] [PATCH v5 11/11] block/backup: use backup-top instead of write notifiers

2019-01-28 Thread Vladimir Sementsov-Ogievskiy
28 янв. 2019 г. 20:40 пользователь Kevin Wolf написал: Am 28.01.2019 um 17:44 hat Vladimir Sementsov-Ogievskiy geschrieben: > 28.01.2019 18:59, Max Reitz wrote: > > On 28.01.19 12:29, Vladimir Sementsov-Ogievskiy wrote: > >> 18.01.2019 17:56, Max Reitz wrote: > >>> On 29.12.18 13:20, Vladimir

Re: [Qemu-block] [PATCH v5 11/11] block/backup: use backup-top instead of write notifiers

2019-01-28 Thread Kevin Wolf
Am 28.01.2019 um 17:44 hat Vladimir Sementsov-Ogievskiy geschrieben: > 28.01.2019 18:59, Max Reitz wrote: > > On 28.01.19 12:29, Vladimir Sementsov-Ogievskiy wrote: > >> 18.01.2019 17:56, Max Reitz wrote: > >>> On 29.12.18 13:20, Vladimir Sementsov-Ogievskiy wrote: > Drop write notifiers and

Re: [Qemu-block] [PATCH v5 11/11] block/backup: use backup-top instead of write notifiers

2019-01-28 Thread Vladimir Sementsov-Ogievskiy
28.01.2019 19:53, Max Reitz wrote: > On 28.01.19 17:44, Vladimir Sementsov-Ogievskiy wrote: >> 28.01.2019 18:59, Max Reitz wrote: >>> On 28.01.19 12:29, Vladimir Sementsov-Ogievskiy wrote: 18.01.2019 17:56, Max Reitz wrote: > On 29.12.18 13:20, Vladimir Sementsov-Ogievskiy wrote: > >

Re: [Qemu-block] [PATCH v5 11/11] block/backup: use backup-top instead of write notifiers

2019-01-28 Thread Max Reitz
On 28.01.19 17:44, Vladimir Sementsov-Ogievskiy wrote: > 28.01.2019 18:59, Max Reitz wrote: >> On 28.01.19 12:29, Vladimir Sementsov-Ogievskiy wrote: >>> 18.01.2019 17:56, Max Reitz wrote: On 29.12.18 13:20, Vladimir Sementsov-Ogievskiy wrote: [...] > @@ -505,8 +474,20 @@ static int

Re: [Qemu-block] [PATCH v5 11/11] block/backup: use backup-top instead of write notifiers

2019-01-28 Thread Vladimir Sementsov-Ogievskiy
28.01.2019 18:59, Max Reitz wrote: > On 28.01.19 12:29, Vladimir Sementsov-Ogievskiy wrote: >> 18.01.2019 17:56, Max Reitz wrote: >>> On 29.12.18 13:20, Vladimir Sementsov-Ogievskiy wrote: Drop write notifiers and use filter node instead. Changes: 1. copy-before-writes now handled

Re: [Qemu-block] [PATCH v5 11/11] block/backup: use backup-top instead of write notifiers

2019-01-28 Thread Max Reitz
On 28.01.19 12:29, Vladimir Sementsov-Ogievskiy wrote: > 18.01.2019 17:56, Max Reitz wrote: >> On 29.12.18 13:20, Vladimir Sementsov-Ogievskiy wrote: >>> Drop write notifiers and use filter node instead. Changes: >>> >>> 1. copy-before-writes now handled by filter node, so, drop all >>>

Re: [Qemu-block] [PATCH v5 11/11] block/backup: use backup-top instead of write notifiers

2019-01-28 Thread Vladimir Sementsov-Ogievskiy
18.01.2019 17:56, Max Reitz wrote: > On 29.12.18 13:20, Vladimir Sementsov-Ogievskiy wrote: >> Drop write notifiers and use filter node instead. Changes: >> >> 1. copy-before-writes now handled by filter node, so, drop all >> is_write_notifier arguments. >> >> 2. we don't have intersecting

Re: [Qemu-block] [PATCH v5 11/11] block/backup: use backup-top instead of write notifiers

2019-01-18 Thread Max Reitz
On 29.12.18 13:20, Vladimir Sementsov-Ogievskiy wrote: > Drop write notifiers and use filter node instead. Changes: > > 1. copy-before-writes now handled by filter node, so, drop all >is_write_notifier arguments. > > 2. we don't have intersecting requests, so their handling is dropped. >

[Qemu-block] [PATCH v5 11/11] block/backup: use backup-top instead of write notifiers

2018-12-29 Thread Vladimir Sementsov-Ogievskiy
Drop write notifiers and use filter node instead. Changes: 1. copy-before-writes now handled by filter node, so, drop all is_write_notifier arguments. 2. we don't have intersecting requests, so their handling is dropped. Instead, synchronization works as follows: when backup or backup-top