Re: [Qemu-block] [PATCH v5 2/3] file-posix: Drop s->lock_fd

2018-11-16 Thread Max Reitz
On 16.11.18 15:02, Max Reitz wrote: > On 16.11.18 14:58, Alberto Garcia wrote: >> On Fri 16 Nov 2018 02:34:25 PM CET, Max Reitz wrote: >>> To me that looks like a problem in the general reopen code. >>> raw_reopen_prepare() is called and succeeds. Then >>> bdrv_reopen_prepare() notices the option

Re: [Qemu-block] [PATCH v5 2/3] file-posix: Drop s->lock_fd

2018-11-16 Thread Max Reitz
On 16.11.18 14:58, Alberto Garcia wrote: > On Fri 16 Nov 2018 02:34:25 PM CET, Max Reitz wrote: >> To me that looks like a problem in the general reopen code. >> raw_reopen_prepare() is called and succeeds. Then >> bdrv_reopen_prepare() notices the option wasn't handled and therefore >> fails.

Re: [Qemu-block] [PATCH v5 2/3] file-posix: Drop s->lock_fd

2018-11-16 Thread Alberto Garcia
On Fri 16 Nov 2018 02:34:25 PM CET, Max Reitz wrote: > To me that looks like a problem in the general reopen code. > raw_reopen_prepare() is called and succeeds. Then > bdrv_reopen_prepare() notices the option wasn't handled and therefore > fails. bdrv_reopen_multiple() thus doesn't set

Re: [Qemu-block] [PATCH v5 2/3] file-posix: Drop s->lock_fd

2018-11-16 Thread Max Reitz
On 14.11.18 14:54, Alberto Garcia wrote: > On Thu 11 Oct 2018 09:21:34 AM CEST, Fam Zheng wrote: >> The lock_fd field is not strictly necessary because transferring locked >> bytes from old fd to the new one shouldn't fail anyway. This spares the >> user one fd per image. >> >> Signed-off-by: Fam

Re: [Qemu-block] [PATCH v5 2/3] file-posix: Drop s->lock_fd

2018-11-14 Thread Alberto Garcia
On Thu 11 Oct 2018 09:21:34 AM CEST, Fam Zheng wrote: > The lock_fd field is not strictly necessary because transferring locked > bytes from old fd to the new one shouldn't fail anyway. This spares the > user one fd per image. > > Signed-off-by: Fam Zheng > Reviewed-by: Max Reitz One of my

[Qemu-block] [PATCH v5 2/3] file-posix: Drop s->lock_fd

2018-10-11 Thread Fam Zheng
The lock_fd field is not strictly necessary because transferring locked bytes from old fd to the new one shouldn't fail anyway. This spares the user one fd per image. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- block/file-posix.c | 37 + 1 file