Re: [Qemu-block] [PATCH v5 2/4] quorum: implement bdrv_add_child() and bdrv_del_child()

2015-10-12 Thread Alberto Garcia
On Fri 09 Oct 2015 05:51:55 PM CEST, Max Reitz wrote: +s->bs = g_renew(BlockDriverState *, s->bs, s->max_children + 1); +s->bs[s->num_children] = NULL; +s->max_children++; +} >>> >>> Just a suggestion, please feel free to ignore

Re: [Qemu-block] [PATCH v5 2/4] quorum: implement bdrv_add_child() and bdrv_del_child()

2015-10-09 Thread Max Reitz
On 08.10.2015 10:12, Alberto Garcia wrote: > On Wed 07 Oct 2015 08:51:21 PM CEST, Max Reitz wrote: >>> +if (s->num_children == s->max_children) { >>> +if (s->max_children >= INT_MAX) { >> >> Opposing Berto (:-)), I like >= even if the > part is actually >>

Re: [Qemu-block] [PATCH v5 2/4] quorum: implement bdrv_add_child() and bdrv_del_child()

2015-10-08 Thread Alberto Garcia
On Wed 07 Oct 2015 08:51:21 PM CEST, Max Reitz wrote: >> +if (s->num_children == s->max_children) { >> +if (s->max_children >= INT_MAX) { > > Opposing Berto (:-)), I like >= even if the > part is actually > impossible. I myself like to use constructs such as: > >

Re: [Qemu-block] [PATCH v5 2/4] quorum: implement bdrv_add_child() and bdrv_del_child()

2015-10-07 Thread Wen Congyang
On 10/07/2015 10:12 PM, Alberto Garcia wrote: > On Tue 22 Sep 2015 09:44:20 AM CEST, Wen Congyang wrote: > >> +++ b/block/quorum.c >> @@ -66,6 +66,9 @@ typedef struct QuorumVotes { >> typedef struct BDRVQuorumState { >> BlockDriverState **bs; /* children BlockDriverStates */ >> int

Re: [Qemu-block] [PATCH v5 2/4] quorum: implement bdrv_add_child() and bdrv_del_child()

2015-10-07 Thread Alberto Garcia
On Tue 22 Sep 2015 09:44:20 AM CEST, Wen Congyang wrote: > +++ b/block/quorum.c > @@ -66,6 +66,9 @@ typedef struct QuorumVotes { > typedef struct BDRVQuorumState { > BlockDriverState **bs; /* children BlockDriverStates */ > int num_children; /* children count */ > +int

Re: [Qemu-block] [PATCH v5 2/4] quorum: implement bdrv_add_child() and bdrv_del_child()

2015-10-07 Thread Max Reitz
On 22.09.2015 09:44, Wen Congyang wrote: > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > --- > block.c | 6 ++--- > block/quorum.c| 72 >

[Qemu-block] [PATCH v5 2/4] quorum: implement bdrv_add_child() and bdrv_del_child()

2015-09-22 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block.c | 6 ++--- block/quorum.c| 72 +--