Re: [Qemu-block] [PATCH v6 20/42] block/snapshot: Fix fallback

2019-09-10 Thread Max Reitz
On 10.09.19 14:49, Kevin Wolf wrote: > Am 10.09.2019 um 14:04 hat Max Reitz geschrieben: >> On 10.09.19 13:56, Kevin Wolf wrote: >>> Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: If the top node's driver does not provide snapshot functionality and we want to fall back to a node down

Re: [Qemu-block] [PATCH v6 20/42] block/snapshot: Fix fallback

2019-09-10 Thread Kevin Wolf
Am 10.09.2019 um 14:04 hat Max Reitz geschrieben: > On 10.09.19 13:56, Kevin Wolf wrote: > > Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > >> If the top node's driver does not provide snapshot functionality and we > >> want to fall back to a node down the chain, we need to snapshot all > >>

Re: [Qemu-block] [PATCH v6 20/42] block/snapshot: Fix fallback

2019-09-10 Thread Max Reitz
On 10.09.19 13:56, Kevin Wolf wrote: > Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: >> If the top node's driver does not provide snapshot functionality and we >> want to fall back to a node down the chain, we need to snapshot all >> non-COW children. For simplicity's sake, just do not fall

Re: [Qemu-block] [PATCH v6 20/42] block/snapshot: Fix fallback

2019-09-10 Thread Kevin Wolf
Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > If the top node's driver does not provide snapshot functionality and we > want to fall back to a node down the chain, we need to snapshot all > non-COW children. For simplicity's sake, just do not fall back if there > is more than one such

Re: [Qemu-block] [PATCH v6 20/42] block/snapshot: Fix fallback

2019-08-12 Thread Max Reitz
On 10.08.19 18:34, Vladimir Sementsov-Ogievskiy wrote: > 09.08.2019 19:13, Max Reitz wrote: >> If the top node's driver does not provide snapshot functionality and we >> want to fall back to a node down the chain, we need to snapshot all >> non-COW children. For simplicity's sake, just do not

Re: [Qemu-block] [PATCH v6 20/42] block/snapshot: Fix fallback

2019-08-10 Thread Vladimir Sementsov-Ogievskiy
09.08.2019 19:13, Max Reitz wrote: > If the top node's driver does not provide snapshot functionality and we > want to fall back to a node down the chain, we need to snapshot all > non-COW children. For simplicity's sake, just do not fall back if there > is more than one such child. > >

[Qemu-block] [PATCH v6 20/42] block/snapshot: Fix fallback

2019-08-09 Thread Max Reitz
If the top node's driver does not provide snapshot functionality and we want to fall back to a node down the chain, we need to snapshot all non-COW children. For simplicity's sake, just do not fall back if there is more than one such child. bdrv_snapshot_goto() becomes a bit weird because we may