Re: [Qemu-block] [PATCH v6 3/4] block: add a 'blockdev-snapshot' QMP command

2015-10-07 Thread Kevin Wolf
Am 06.10.2015 um 17:49 hat Alberto Garcia geschrieben: > On Tue 06 Oct 2015 05:30:07 PM CEST, Kevin Wolf wrote: > >> -options = qdict_new(); > >> -if (has_snapshot_node_name) { > >> -qdict_put(options, "node-name", > >> - qstring_from_str(snapshot_node_name)); > >>

Re: [Qemu-block] [PATCH v6 3/4] block: add a 'blockdev-snapshot' QMP command

2015-10-06 Thread Alberto Garcia
On Tue 06 Oct 2015 05:30:07 PM CEST, Kevin Wolf wrote: >> -options = qdict_new(); >> -if (has_snapshot_node_name) { >> -qdict_put(options, "node-name", >> - qstring_from_str(snapshot_node_name)); >> +if (snapshot_node_name &&

Re: [Qemu-block] [PATCH v6 3/4] block: add a 'blockdev-snapshot' QMP command

2015-10-06 Thread Kevin Wolf
Am 22.09.2015 um 15:28 hat Alberto Garcia geschrieben: > One of the limitations of the 'blockdev-snapshot-sync' command is that > it does not allow passing BlockdevOptions to the newly created > snapshots, so they are always opened using the default values. > > Extending the command to allow

Re: [Qemu-block] [PATCH v6 3/4] block: add a 'blockdev-snapshot' QMP command

2015-09-23 Thread Alberto Garcia
On Tue 22 Sep 2015 06:38:27 PM CEST, Max Reitz wrote: >> +.name = "blockdev-snapshot", >> +.args_type = "node:s,overlay:s", >> +.mhandler.cmd_new = qmp_marshal_input_blockdev_snapshot, > > As of 7fad30f06eb6aa57aaa8f3d264288f24ae7646f0, this needs to be >

[Qemu-block] [PATCH v6 3/4] block: add a 'blockdev-snapshot' QMP command

2015-09-22 Thread Alberto Garcia
One of the limitations of the 'blockdev-snapshot-sync' command is that it does not allow passing BlockdevOptions to the newly created snapshots, so they are always opened using the default values. Extending the command to allow passing options is not a practical solution because there is overlap