Re: [Qemu-block] [Qemu-devel] [PATCH] block/mirror: fix fail to cancel when VM has heavy BLK IO

2018-01-28 Thread Liang Li
On Fri, Jan 26, 2018 at 08:04:08AM -0600, Eric Blake wrote: > On 01/26/2018 12:46 AM, Liang Li wrote: > > The current QMP command is: > > > > { 'command': 'block-job-cancel', 'data': { 'device': 'str', '*force': > > 'bool' } } > > > > 'force' has other meaning which is not used by libvirt, for t

Re: [Qemu-block] [Qemu-devel] [PATCH] block/mirror: fix fail to cancel when VM has heavy BLK IO

2018-01-26 Thread John Snow
On 01/24/2018 02:16 PM, Eric Blake wrote: > On 01/24/2018 12:17 AM, Liang Li wrote: >> We found that when doing drive mirror to a low speed shared storage, >> if there was heavy BLK IO write workload in VM after the 'ready' event, >> drive mirror block job can't be canceled immediately, it would

Re: [Qemu-block] [Qemu-devel] [PATCH] block/mirror: fix fail to cancel when VM has heavy BLK IO

2018-01-26 Thread Eric Blake
On 01/26/2018 12:46 AM, Liang Li wrote: > The current QMP command is: > > { 'command': 'block-job-cancel', 'data': { 'device': 'str', '*force': 'bool' > } } > > 'force' has other meaning which is not used by libvirt, for the change, there > are 3 options: > > a. Now that 'force' is not used by

Re: [Qemu-block] [Qemu-devel] [PATCH] block/mirror: fix fail to cancel when VM has heavy BLK IO

2018-01-25 Thread Liang Li
On Thu, Jan 25, 2018 at 08:48:22AM -0600, Eric Blake wrote: > On 01/24/2018 10:59 PM, Liang Li wrote: > >> > >> There's ongoing work on adding async mirroring; this may be a better > >> solution to the issue you are seeing. > >> > >> https://lists.gnu.org/archive/html/qemu-devel/2018-01/msg05419.ht

Re: [Qemu-block] [Qemu-devel] [PATCH] block/mirror: fix fail to cancel when VM has heavy BLK IO

2018-01-25 Thread Eric Blake
On 01/24/2018 10:59 PM, Liang Li wrote: >> >> There's ongoing work on adding async mirroring; this may be a better >> solution to the issue you are seeing. >> >> https://lists.gnu.org/archive/html/qemu-devel/2018-01/msg05419.html >> > Hi Eric, > > Thinks for your information, I didn't know libvirt

Re: [Qemu-block] [Qemu-devel] [PATCH] block/mirror: fix fail to cancel when VM has heavy BLK IO

2018-01-25 Thread Liang Li
On Wed, Jan 24, 2018 at 01:16:39PM -0600, Eric Blake wrote: > On 01/24/2018 12:17 AM, Liang Li wrote: > > We found that when doing drive mirror to a low speed shared storage, > > if there was heavy BLK IO write workload in VM after the 'ready' event, > > drive mirror block job can't be canceled imm

Re: [Qemu-block] [Qemu-devel] [PATCH] block/mirror: fix fail to cancel when VM has heavy BLK IO

2018-01-24 Thread Eric Blake
On 01/24/2018 12:17 AM, Liang Li wrote: > We found that when doing drive mirror to a low speed shared storage, > if there was heavy BLK IO write workload in VM after the 'ready' event, > drive mirror block job can't be canceled immediately, it would keep > running until the heavy BLK IO workload st