Re: [Qemu-block] [Qemu-devel] [PATCH] block: for jobs, do not clear user_paused until after the resume

2018-08-15 Thread Jeff Cody
On Wed, Aug 15, 2018 at 05:23:43PM -0400, John Snow wrote: > > > On 08/15/2018 11:59 AM, Jeff Cody wrote: > > The function job_cancel_async() will always cause an assert for blockjob > > user resume. We set job->user_paused to false, and then call > > job->driver->user_resume(). In the case of

Re: [Qemu-block] [Qemu-devel] [PATCH] block: for jobs, do not clear user_paused until after the resume

2018-08-15 Thread Jeff Cody
On Wed, Aug 15, 2018 at 04:25:16PM -0500, Eric Blake wrote: > On 08/15/2018 10:59 AM, Jeff Cody wrote: > >The function job_cancel_async() will always cause an assert for blockjob > >user resume. We set job->user_paused to false, and then call > >job->driver->user_resume(). In the case of blockjob

Re: [Qemu-block] [Qemu-devel] [PATCH] block: for jobs, do not clear user_paused until after the resume

2018-08-15 Thread Eric Blake
On 08/15/2018 10:59 AM, Jeff Cody wrote: The function job_cancel_async() will always cause an assert for blockjob user resume. We set job->user_paused to false, and then call job->driver->user_resume(). In the case of blockjobs, this is the block_job_user_resume() function. In that function, w

Re: [Qemu-block] [Qemu-devel] [PATCH] block: for jobs, do not clear user_paused until after the resume

2018-08-15 Thread John Snow
On 08/15/2018 11:59 AM, Jeff Cody wrote: > The function job_cancel_async() will always cause an assert for blockjob > user resume. We set job->user_paused to false, and then call > job->driver->user_resume(). In the case of blockjobs, this is the > block_job_user_resume() function. > > In tha