Re: [Qemu-block] [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

2017-06-07 Thread Max Reitz
On 2017-06-02 00:29, John Snow wrote: > > > On 05/31/2017 09:43 AM, Max Reitz wrote: >> On 2017-05-30 08:50, Vladimir Sementsov-Ogievskiy wrote: >>> Thank you for this scenario. Hmm. >>> >>> So, as I need guarantee that image and bitmap are unchanged, >>> bdrv_set_dirty should return error and

Re: [Qemu-block] [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

2017-06-03 Thread Sementsov-Ogievskiy Vladimir
On 02.06.2017 21:46, John Snow wrote: On 06/02/2017 05:45 AM, Vladimir Sementsov-Ogievskiy wrote: 02.06.2017 12:01, Vladimir Sementsov-Ogievskiy wrote: 02.06.2017 11:56, Vladimir Sementsov-Ogievskiy wrote: 02.06.2017 02:25, John Snow wrote: On 06/01/2017 03:30 AM, Sementsov-Ogievskiy

Re: [Qemu-block] [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

2017-06-02 Thread John Snow
On 06/02/2017 05:45 AM, Vladimir Sementsov-Ogievskiy wrote: > 02.06.2017 12:01, Vladimir Sementsov-Ogievskiy wrote: >> 02.06.2017 11:56, Vladimir Sementsov-Ogievskiy wrote: >>> 02.06.2017 02:25, John Snow wrote: On 06/01/2017 03:30 AM, Sementsov-Ogievskiy Vladimir wrote: > Hi John!

Re: [Qemu-block] [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

2017-06-02 Thread Vladimir Sementsov-Ogievskiy
02.06.2017 12:01, Vladimir Sementsov-Ogievskiy wrote: 02.06.2017 11:56, Vladimir Sementsov-Ogievskiy wrote: 02.06.2017 02:25, John Snow wrote: On 06/01/2017 03:30 AM, Sementsov-Ogievskiy Vladimir wrote: Hi John! Look at our discussion about this in v18 thread. Shortly: readonly is not the

Re: [Qemu-block] [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

2017-06-02 Thread Vladimir Sementsov-Ogievskiy
02.06.2017 11:56, Vladimir Sementsov-Ogievskiy wrote: 02.06.2017 02:25, John Snow wrote: On 06/01/2017 03:30 AM, Sementsov-Ogievskiy Vladimir wrote: Hi John! Look at our discussion about this in v18 thread. Shortly: readonly is not the same as disabled. disabled= bitmap just ignores all

Re: [Qemu-block] [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

2017-06-02 Thread Vladimir Sementsov-Ogievskiy
02.06.2017 02:25, John Snow wrote: On 06/01/2017 03:30 AM, Sementsov-Ogievskiy Vladimir wrote: Hi John! Look at our discussion about this in v18 thread. Shortly: readonly is not the same as disabled. disabled= bitmap just ignores all writes. readonly= writes are not allowed at all. And I

Re: [Qemu-block] [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

2017-06-01 Thread John Snow
On 06/01/2017 03:30 AM, Sementsov-Ogievskiy Vladimir wrote: > Hi John! > > Look at our discussion about this in v18 thread. > > Shortly: readonly is not the same as disabled. disabled= bitmap just > ignores all writes. readonly= writes are not allowed at all. > > And I think, I'll try to go

Re: [Qemu-block] [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

2017-06-01 Thread John Snow
On 05/31/2017 11:53 AM, Max Reitz wrote: > On 2017-05-31 17:05, Vladimir Sementsov-Ogievskiy wrote: >> 31.05.2017 17:44, Max Reitz wrote: >>> On 2017-05-31 16:29, Vladimir Sementsov-Ogievskiy wrote: 31.05.2017 16:43, Max Reitz wrote: > On 2017-05-30 08:50, Vladimir Sementsov-Ogievskiy

Re: [Qemu-block] [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

2017-06-01 Thread John Snow
On 05/31/2017 09:43 AM, Max Reitz wrote: > On 2017-05-30 08:50, Vladimir Sementsov-Ogievskiy wrote: >> Thank you for this scenario. Hmm. >> >> So, as I need guarantee that image and bitmap are unchanged, >> bdrv_set_dirty should return error and fail the whole write. Ok? > > I don't know. That

Re: [Qemu-block] [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

2017-06-01 Thread John Snow
On 06/01/2017 03:30 AM, Sementsov-Ogievskiy Vladimir wrote: > Hi John! > > Look at our discussion about this in v18 thread. > I'm batting zero today; I literally missed that entire subthread. Sigh, thanks, I'll go back and read.

Re: [Qemu-block] [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

2017-06-01 Thread Sementsov-Ogievskiy Vladimir
Hi John! Look at our discussion about this in v18 thread. Shortly: readonly is not the same as disabled. disabled= bitmap just ignores all writes. readonly= writes are not allowed at all. And I think, I'll try to go through way 2: "dirty" field instead of "readonly" (look at v18

Re: [Qemu-block] [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

2017-06-01 Thread Sementsov-Ogievskiy Vladimir
On 01.06.2017 01:58, John Snow wrote: On 05/19/2017 07:02 PM, John Snow wrote: On 05/03/2017 08:25 AM, Vladimir Sementsov-Ogievskiy wrote: It will be needed in following commits for persistent bitmaps. If bitmap is loaded from read-only storage (and we can't mark it "in use" in this

Re: [Qemu-block] [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

2017-05-31 Thread John Snow
On 05/30/2017 04:17 AM, Vladimir Sementsov-Ogievskiy wrote: > It will be needed in following commits for persistent bitmaps. > If bitmap is loaded from read-only storage (and we can't mark it > "in use" in this storage) corresponding BdrvDirtyBitmap should be > read-only. > > Signed-off-by:

Re: [Qemu-block] [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

2017-05-31 Thread John Snow
On 05/19/2017 07:02 PM, John Snow wrote: > > > On 05/03/2017 08:25 AM, Vladimir Sementsov-Ogievskiy wrote: >> It will be needed in following commits for persistent bitmaps. >> If bitmap is loaded from read-only storage (and we can't mark it >> "in use" in this storage) corresponding

Re: [Qemu-block] [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

2017-05-25 Thread Vladimir Sementsov-Ogievskiy
20.05.2017 02:02, John Snow wrote: On 05/03/2017 08:25 AM, Vladimir Sementsov-Ogievskiy wrote: It will be needed in following commits for persistent bitmaps. If bitmap is loaded from read-only storage (and we can't mark it "in use" in this storage) corresponding BdrvDirtyBitmap should be

Re: [Qemu-block] [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

2017-05-19 Thread John Snow
On 05/03/2017 08:25 AM, Vladimir Sementsov-Ogievskiy wrote: > It will be needed in following commits for persistent bitmaps. > If bitmap is loaded from read-only storage (and we can't mark it > "in use" in this storage) corresponding BdrvDirtyBitmap should be > read-only. > > Signed-off-by: