Re: [Qemu-block] [Qemu-devel] [PATCH for-2.9] block/archipelago: Make it compile

2017-03-08 Thread Eric Blake
On 03/08/2017 12:46 PM, Kevin Wolf wrote: >>> Oh, I meant to add: >>> >>> Should probably mention that it was commit da34e65 that introduced the >>> problem (if I'm right?). Does that mean we have not been compiling >>> archipelago.c since Mar 2016? >> >> At least here on my machine it does indeed

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.9] block/archipelago: Make it compile

2017-03-08 Thread Kevin Wolf
Am 08.03.2017 um 19:32 hat Max Reitz geschrieben: > On 08.03.2017 19:28, Eric Blake wrote: > > On 03/08/2017 12:25 PM, Eric Blake wrote: > >> On 03/08/2017 12:18 PM, Max Reitz wrote: > >>> In order to use error_setg() and similar functions, we need to include > >>> qapi/error.h. > >>> > >>> Signed-

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.9] block/archipelago: Make it compile

2017-03-08 Thread Philippe Mathieu-Daudé
On 03/08/2017 03:25 PM, Eric Blake wrote: On 03/08/2017 12:18 PM, Max Reitz wrote: In order to use error_setg() and similar functions, we need to include qapi/error.h. Signed-off-by: Max Reitz --- block/archipelago.c | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Eric Blake Reviewed-

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.9] block/archipelago: Make it compile

2017-03-08 Thread Max Reitz
On 08.03.2017 19:28, Eric Blake wrote: > On 03/08/2017 12:25 PM, Eric Blake wrote: >> On 03/08/2017 12:18 PM, Max Reitz wrote: >>> In order to use error_setg() and similar functions, we need to include >>> qapi/error.h. >>> >>> Signed-off-by: Max Reitz >>> --- >>> block/archipelago.c | 1 + >>> 1

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.9] block/archipelago: Make it compile

2017-03-08 Thread Eric Blake
On 03/08/2017 12:25 PM, Eric Blake wrote: > On 03/08/2017 12:18 PM, Max Reitz wrote: >> In order to use error_setg() and similar functions, we need to include >> qapi/error.h. >> >> Signed-off-by: Max Reitz >> --- >> block/archipelago.c | 1 + >> 1 file changed, 1 insertion(+) > > Reviewed-by: E

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.9] block/archipelago: Make it compile

2017-03-08 Thread Max Reitz
On 08.03.2017 19:25, Eric Blake wrote: > On 03/08/2017 12:18 PM, Max Reitz wrote: >> In order to use error_setg() and similar functions, we need to include >> qapi/error.h. >> >> Signed-off-by: Max Reitz >> --- >> block/archipelago.c | 1 + >> 1 file changed, 1 insertion(+) > > Reviewed-by: Eric

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.9] block/archipelago: Make it compile

2017-03-08 Thread Eric Blake
On 03/08/2017 12:18 PM, Max Reitz wrote: > In order to use error_setg() and similar functions, we need to include > qapi/error.h. > > Signed-off-by: Max Reitz > --- > block/archipelago.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Eric Blake Does this mean our automated buildbots are