Re: [Qemu-block] [Qemu-devel] [PATCH v1 05/15] crypto: add block encryption framework

2016-01-19 Thread Daniel P. Berrange
On Mon, Jan 18, 2016 at 12:48:56PM -0700, Eric Blake wrote: > On 01/14/2016 05:16 AM, Daniel P. Berrange wrote: > > >>> +# @qcowaes: QCow/QCow2 built-in AES-CBC encryption. Do not use > >>> +# > >> > >> Well, the only reason to use it would be to read data off an old > >> insecurely-encrypted

Re: [Qemu-block] [Qemu-devel] [PATCH v1 05/15] crypto: add block encryption framework

2016-01-18 Thread Eric Blake
On 01/14/2016 05:16 AM, Daniel P. Berrange wrote: >>> +# @qcowaes: QCow/QCow2 built-in AES-CBC encryption. Do not use >>> +# >> >> Well, the only reason to use it would be to read data off an old >> insecurely-encrypted qcow2 file; so maybe it should read "Do not use on >> new files" > > Yep >

Re: [Qemu-block] [Qemu-devel] [PATCH v1 05/15] crypto: add block encryption framework

2016-01-14 Thread Daniel P. Berrange
On Wed, Jan 13, 2016 at 04:40:31PM -0700, Eric Blake wrote: > On 01/12/2016 11:56 AM, Daniel P. Berrange wrote: > > Add a generic framework for support different block encryption > > formats. Upon instantiating a QCryptoBlock object, it will read > > the encryption header and extract the

Re: [Qemu-block] [Qemu-devel] [PATCH v1 05/15] crypto: add block encryption framework

2016-01-13 Thread Eric Blake
On 01/12/2016 11:56 AM, Daniel P. Berrange wrote: > Add a generic framework for support different block encryption > formats. Upon instantiating a QCryptoBlock object, it will read > the encryption header and extract the encryption keys. It is > then possible to call methods to encrypt/decrypt