Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/6] Acquire the AioContext during _realize()

2019-01-22 Thread Alberto Garcia
On Fri 18 Jan 2019 11:14:15 AM CET, Kevin Wolf wrote: > There are two ways to trigger the crash even without > x-blockdev-set-iothread: > > * device_del, then device_add for a device with iothread (virtio-scsi; > may or may not exist with virtio-blk) >

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/6] Acquire the AioContext during _realize()

2019-01-18 Thread Kevin Wolf
Am 18.01.2019 um 10:56 hat Stefan Hajnoczi geschrieben: > On Thu, Jan 17, 2019 at 02:24:10PM +0100, Alberto Garcia wrote: > > On Wed 16 Jan 2019 02:54:44 PM CET, Stefan Hajnoczi wrote: > > > This patch series makes virtio-blk and virtio-scsi more robust, > > > although I haven't checked what

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/6] Acquire the AioContext during _realize()

2019-01-18 Thread Stefan Hajnoczi
On Thu, Jan 17, 2019 at 02:24:10PM +0100, Alberto Garcia wrote: > On Wed 16 Jan 2019 02:54:44 PM CET, Stefan Hajnoczi wrote: > > This patch series makes virtio-blk and virtio-scsi more robust, > > although I haven't checked what happens if the drive is attached to a > > different IOThread than the

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/6] Acquire the AioContext during _realize()

2019-01-17 Thread Alberto Garcia
On Wed 16 Jan 2019 02:54:44 PM CET, Stefan Hajnoczi wrote: > The x-blockdev-set-iothread command is for low-level tests so I don't > expect users to invoke it. As I said in a different e-mail maybe this is not necessary then. > This patch series makes virtio-blk and virtio-scsi more robust, >

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/6] Acquire the AioContext during _realize()

2019-01-16 Thread Stefan Hajnoczi
On Mon, Jan 14, 2019 at 04:23:58PM +0200, Alberto Garcia wrote: > This series acquires the AioContext in the _realize() functions of > several devices before making use of their block backends. This fixes > at least a couple of crashes (in virtio-blk and scsi). The other > devices don't currently