Re: [Qemu-block] [Qemu-devel] [PATCH v2 01/18] qapi/block-core: Introduce BackupCommon

2019-07-08 Thread John Snow
On 7/6/19 12:03 AM, Markus Armbruster wrote: > John Snow writes: > >> On 7/5/19 10:14 AM, Markus Armbruster wrote: >>> John Snow writes: >>> drive-backup and blockdev-backup have an awful lot of things in common that are the same. Let's fix that. I don't deduplicate

Re: [Qemu-block] [Qemu-devel] [PATCH v2 01/18] qapi/block-core: Introduce BackupCommon

2019-07-05 Thread Markus Armbruster
John Snow writes: > On 7/5/19 10:14 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> drive-backup and blockdev-backup have an awful lot of things in common >>> that are the same. Let's fix that. >>> >>> I don't deduplicate 'target', because the semantics actually did change >>> between

Re: [Qemu-block] [Qemu-devel] [PATCH v2 01/18] qapi/block-core: Introduce BackupCommon

2019-07-05 Thread John Snow
On 7/5/19 10:14 AM, Markus Armbruster wrote: > John Snow writes: > >> drive-backup and blockdev-backup have an awful lot of things in common >> that are the same. Let's fix that. >> >> I don't deduplicate 'target', because the semantics actually did change >> between each structure. Leave

Re: [Qemu-block] [Qemu-devel] [PATCH v2 01/18] qapi/block-core: Introduce BackupCommon

2019-07-05 Thread Markus Armbruster
John Snow writes: > drive-backup and blockdev-backup have an awful lot of things in common > that are the same. Let's fix that. > > I don't deduplicate 'target', because the semantics actually did change > between each structure. Leave that one alone so it can be documented > separately. > >