Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/5] block/nvme: don't flip CQ phase bits

2019-06-11 Thread Maxim Levitsky
On Fri, 2019-06-07 at 15:28 -0400, John Snow wrote: > > On 6/7/19 7:08 AM, Paolo Bonzini wrote: > > On 06/06/19 23:23, John Snow wrote: > > > So: This looks right; does this fix a bug that can be observed? Do we > > > have any regression tests for block/NVMe? > > > > I don't think it fixes a

Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/5] block/nvme: don't flip CQ phase bits

2019-06-07 Thread John Snow
On 6/7/19 7:08 AM, Paolo Bonzini wrote: > On 06/06/19 23:23, John Snow wrote: >> So: This looks right; does this fix a bug that can be observed? Do we >> have any regression tests for block/NVMe? > > I don't think it fixes a bug; by the time the CQ entry is picked up by > QEMU, the device is