Re: [Qemu-block] [Qemu-devel] [PATCH v3 04/13] netmap: Drop netmap_can_send

2015-06-02 Thread Stefan Hajnoczi
On Wed, May 27, 2015 at 03:24:38PM +0800, Fam Zheng wrote: > On Tue, 05/26 10:18, Stefan Hajnoczi wrote: > > On Mon, May 25, 2015 at 11:51:23AM +0800, Fam Zheng wrote: > > > On Tue, 05/19 15:54, Stefan Hajnoczi wrote: > > > > On Tue, May 19, 2015 at 10:51:01AM +, Fam Zheng wrote: > > > > > This

Re: [Qemu-block] [Qemu-devel] [PATCH v3 04/13] netmap: Drop netmap_can_send

2015-05-27 Thread Fam Zheng
On Tue, 05/26 10:18, Stefan Hajnoczi wrote: > On Mon, May 25, 2015 at 11:51:23AM +0800, Fam Zheng wrote: > > On Tue, 05/19 15:54, Stefan Hajnoczi wrote: > > > On Tue, May 19, 2015 at 10:51:01AM +, Fam Zheng wrote: > > > > This callback is called by main loop before polling s->fd, if it returns

Re: [Qemu-block] [Qemu-devel] [PATCH v3 04/13] netmap: Drop netmap_can_send

2015-05-26 Thread Stefan Hajnoczi
On Mon, May 25, 2015 at 11:51:23AM +0800, Fam Zheng wrote: > On Tue, 05/19 15:54, Stefan Hajnoczi wrote: > > On Tue, May 19, 2015 at 10:51:01AM +, Fam Zheng wrote: > > > This callback is called by main loop before polling s->fd, if it returns > > > false, the fd will not be polled in this itera

Re: [Qemu-block] [Qemu-devel] [PATCH v3 04/13] netmap: Drop netmap_can_send

2015-05-24 Thread Fam Zheng
On Tue, 05/19 15:54, Stefan Hajnoczi wrote: > On Tue, May 19, 2015 at 10:51:01AM +, Fam Zheng wrote: > > This callback is called by main loop before polling s->fd, if it returns > > false, the fd will not be polled in this iteration. > > > > This is redundant with checks inside read callback.

Re: [Qemu-block] [Qemu-devel] [PATCH v3 04/13] netmap: Drop netmap_can_send

2015-05-19 Thread Stefan Hajnoczi
On Tue, May 19, 2015 at 10:51:01AM +, Fam Zheng wrote: > This callback is called by main loop before polling s->fd, if it returns > false, the fd will not be polled in this iteration. > > This is redundant with checks inside read callback. After this patch, > the data will be copied from s->fd