On 08.06.2018 22:05, Laurent Vivier wrote:
> It's only 32 bytes, and this simplifies the dp8393x_get()/
> dp8393x_put() interface.
Maybe not worth the effort ... or do you need this in a later patch,
too? If so, please mention it in the patch description here.
> Signed-off-by: Laurent Vivier <laur...@vivier.eu>
> ---
> hw/net/dp8393x.c | 107
> ++++++++++++++++++++++++++-----------------------------
> 1 file changed, 51 insertions(+), 56 deletions(-)
>
> diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c
> index 5061474e6b..40e5f8257b 100644
> --- a/hw/net/dp8393x.c
> +++ b/hw/net/dp8393x.c
> @@ -168,6 +168,7 @@ typedef struct dp8393xState {
>
> /* Temporaries */
> uint8_t tx_buffer[0x10000];
> + uint16_t data[16];
Why 16? The biggest array that you replaced has only 12 entries...
Also, while you're at it, maybe change the name of the variable
("dma_data"?) or add a comment with a short explanation ?
Thomas
