Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-15 Thread Dr. David Alan Gilbert
* Denis Plotnikov (dplotni...@virtuozzo.com) wrote: > > > On 13.02.2018 18:05, Dr. David Alan Gilbert wrote: > > * Denis V. Lunev (d...@virtuozzo.com) wrote: > > > On 02/13/2018 05:59 PM, Dr. David Alan Gilbert wrote: > > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > > > On Tue,

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Denis V. Lunev
On 02/13/2018 07:46 PM, Eric Blake wrote: > On 02/13/2018 08:48 AM, Daniel P. Berrangé wrote: No, that's policy decision that doesn't matter from QMP pov. If the mgmt app wants the snapshot to be wrt to the initial time, it can simply invoke the "stop" QMP command before doing

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Denis Plotnikov
On 13.02.2018 17:43, Kevin Wolf wrote: Am 13.02.2018 um 15:30 hat Roman Kagan geschrieben: On Tue, Feb 13, 2018 at 11:50:24AM +0100, Kevin Wolf wrote: Am 11.01.2018 um 14:04 hat Daniel P. Berrange geschrieben: Then you could just use the regular migrate QMP commands for loading and saving

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Denis Plotnikov
On 13.02.2018 18:05, Dr. David Alan Gilbert wrote: * Denis V. Lunev (d...@virtuozzo.com) wrote: On 02/13/2018 05:59 PM, Dr. David Alan Gilbert wrote: * Daniel P. Berrangé (berra...@redhat.com) wrote: On Tue, Feb 13, 2018 at 03:45:21PM +0100, Kevin Wolf wrote: Am 13.02.2018 um 15:36 hat

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Eric Blake
On 02/13/2018 08:48 AM, Daniel P. Berrangé wrote: No, that's policy decision that doesn't matter from QMP pov. If the mgmt app wants the snapshot to be wrt to the initial time, it can simply invoke the "stop" QMP command before doing the live migration and "cont" afterwards. That would be

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Kevin Wolf
Am 13.02.2018 um 16:30 hat Daniel P. Berrangé geschrieben: > On Tue, Feb 13, 2018 at 04:23:21PM +0100, Kevin Wolf wrote: > > Am 13.02.2018 um 15:58 hat Daniel P. Berrangé geschrieben: > > > On Tue, Feb 13, 2018 at 03:43:10PM +0100, Kevin Wolf wrote: > > > > Am 13.02.2018 um 15:30 hat Roman Kagan

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Denis V. Lunev
On 02/13/2018 06:27 PM, Dr. David Alan Gilbert wrote: > * Roman Kagan (rka...@virtuozzo.com) wrote: >> On Tue, Feb 13, 2018 at 03:05:03PM +, Dr. David Alan Gilbert wrote: >>> * Denis V. Lunev (d...@virtuozzo.com) wrote: On 02/13/2018 05:59 PM, Dr. David Alan Gilbert wrote: > * Daniel

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Daniel P . Berrangé
On Tue, Feb 13, 2018 at 04:23:21PM +0100, Kevin Wolf wrote: > Am 13.02.2018 um 15:58 hat Daniel P. Berrangé geschrieben: > > On Tue, Feb 13, 2018 at 03:43:10PM +0100, Kevin Wolf wrote: > > > Am 13.02.2018 um 15:30 hat Roman Kagan geschrieben: > > > > On Tue, Feb 13, 2018 at 11:50:24AM +0100, Kevin

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Dr. David Alan Gilbert
* Roman Kagan (rka...@virtuozzo.com) wrote: > On Tue, Feb 13, 2018 at 03:05:03PM +, Dr. David Alan Gilbert wrote: > > * Denis V. Lunev (d...@virtuozzo.com) wrote: > > > On 02/13/2018 05:59 PM, Dr. David Alan Gilbert wrote: > > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > >> That

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Kevin Wolf
Am 13.02.2018 um 15:58 hat Daniel P. Berrangé geschrieben: > On Tue, Feb 13, 2018 at 03:43:10PM +0100, Kevin Wolf wrote: > > Am 13.02.2018 um 15:30 hat Roman Kagan geschrieben: > > > On Tue, Feb 13, 2018 at 11:50:24AM +0100, Kevin Wolf wrote: > > > > Am 11.01.2018 um 14:04 hat Daniel P. Berrange

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Dr. David Alan Gilbert
* Denis V. Lunev (d...@virtuozzo.com) wrote: > On 02/13/2018 05:59 PM, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > >> On Tue, Feb 13, 2018 at 03:45:21PM +0100, Kevin Wolf wrote: > >>> Am 13.02.2018 um 15:36 hat Daniel P. Berrangé geschrieben: > On

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Denis V. Lunev
On 02/13/2018 05:59 PM, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: >> On Tue, Feb 13, 2018 at 03:45:21PM +0100, Kevin Wolf wrote: >>> Am 13.02.2018 um 15:36 hat Daniel P. Berrangé geschrieben: On Tue, Feb 13, 2018 at 05:30:02PM +0300, Roman Kagan wrote:

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Tue, Feb 13, 2018 at 03:45:21PM +0100, Kevin Wolf wrote: > > Am 13.02.2018 um 15:36 hat Daniel P. Berrangé geschrieben: > > > On Tue, Feb 13, 2018 at 05:30:02PM +0300, Roman Kagan wrote: > > > > On Tue, Feb 13, 2018 at 11:50:24AM +0100, Kevin

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Daniel P . Berrangé
On Tue, Feb 13, 2018 at 03:43:10PM +0100, Kevin Wolf wrote: > Am 13.02.2018 um 15:30 hat Roman Kagan geschrieben: > > On Tue, Feb 13, 2018 at 11:50:24AM +0100, Kevin Wolf wrote: > > > Am 11.01.2018 um 14:04 hat Daniel P. Berrange geschrieben: > > > > Then you could just use the regular migrate QMP

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Denis V. Lunev
On 02/13/2018 05:48 PM, Daniel P. Berrangé wrote: > On Tue, Feb 13, 2018 at 03:45:21PM +0100, Kevin Wolf wrote: >> Am 13.02.2018 um 15:36 hat Daniel P. Berrangé geschrieben: >>> On Tue, Feb 13, 2018 at 05:30:02PM +0300, Roman Kagan wrote: On Tue, Feb 13, 2018 at 11:50:24AM +0100, Kevin Wolf

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Denis V. Lunev
On 02/13/2018 05:43 PM, Kevin Wolf wrote: > Am 13.02.2018 um 15:30 hat Roman Kagan geschrieben: >> On Tue, Feb 13, 2018 at 11:50:24AM +0100, Kevin Wolf wrote: >>> Am 11.01.2018 um 14:04 hat Daniel P. Berrange geschrieben: Then you could just use the regular migrate QMP commands for loading

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Daniel P . Berrangé
On Tue, Feb 13, 2018 at 03:45:21PM +0100, Kevin Wolf wrote: > Am 13.02.2018 um 15:36 hat Daniel P. Berrangé geschrieben: > > On Tue, Feb 13, 2018 at 05:30:02PM +0300, Roman Kagan wrote: > > > On Tue, Feb 13, 2018 at 11:50:24AM +0100, Kevin Wolf wrote: > > > > Am 11.01.2018 um 14:04 hat Daniel P.

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Kevin Wolf
Am 13.02.2018 um 15:36 hat Daniel P. Berrangé geschrieben: > On Tue, Feb 13, 2018 at 05:30:02PM +0300, Roman Kagan wrote: > > On Tue, Feb 13, 2018 at 11:50:24AM +0100, Kevin Wolf wrote: > > > Am 11.01.2018 um 14:04 hat Daniel P. Berrange geschrieben: > > > > Then you could just use the regular

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Kevin Wolf
Am 13.02.2018 um 15:30 hat Roman Kagan geschrieben: > On Tue, Feb 13, 2018 at 11:50:24AM +0100, Kevin Wolf wrote: > > Am 11.01.2018 um 14:04 hat Daniel P. Berrange geschrieben: > > > Then you could just use the regular migrate QMP commands for loading > > > and saving snapshots. > > > > Yes, you

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Daniel P . Berrangé
On Tue, Feb 13, 2018 at 05:30:02PM +0300, Roman Kagan wrote: > On Tue, Feb 13, 2018 at 11:50:24AM +0100, Kevin Wolf wrote: > > Am 11.01.2018 um 14:04 hat Daniel P. Berrange geschrieben: > > > Then you could just use the regular migrate QMP commands for loading > > > and saving snapshots. > > > >

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Daniel P . Berrangé
On Tue, Feb 13, 2018 at 02:20:00PM +0100, Kevin Wolf wrote: > Am 13.02.2018 um 12:51 hat Daniel P. Berrangé geschrieben: > > On Tue, Feb 13, 2018 at 11:43:55AM +, Dr. David Alan Gilbert wrote: > > > * Kevin Wolf (kw...@redhat.com) wrote: > > > > Am 11.01.2018 um 14:04 hat Daniel P. Berrange

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Kevin Wolf
Am 13.02.2018 um 12:51 hat Daniel P. Berrangé geschrieben: > On Tue, Feb 13, 2018 at 11:43:55AM +, Dr. David Alan Gilbert wrote: > > * Kevin Wolf (kw...@redhat.com) wrote: > > > Am 11.01.2018 um 14:04 hat Daniel P. Berrange geschrieben: > > > > On Thu, Jan 11, 2018 at 01:46:38PM +0100, Max

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Daniel P . Berrangé
On Tue, Feb 13, 2018 at 11:43:55AM +, Dr. David Alan Gilbert wrote: > * Kevin Wolf (kw...@redhat.com) wrote: > > Am 11.01.2018 um 14:04 hat Daniel P. Berrange geschrieben: > > > On Thu, Jan 11, 2018 at 01:46:38PM +0100, Max Reitz wrote: > > > > On 2018-01-08 14:52, Eric Blake wrote: > > > > >

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 11.01.2018 um 14:04 hat Daniel P. Berrange geschrieben: > > On Thu, Jan 11, 2018 at 01:46:38PM +0100, Max Reitz wrote: > > > On 2018-01-08 14:52, Eric Blake wrote: > > > > On 01/07/2018 06:23 AM, Richard Palethorpe wrote: > > > >> Add QAPI wrapper

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-02-13 Thread Kevin Wolf
Am 11.01.2018 um 14:04 hat Daniel P. Berrange geschrieben: > On Thu, Jan 11, 2018 at 01:46:38PM +0100, Max Reitz wrote: > > On 2018-01-08 14:52, Eric Blake wrote: > > > On 01/07/2018 06:23 AM, Richard Palethorpe wrote: > > >> Add QAPI wrapper functions for the existing snapshot functionality.

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-01-11 Thread Daniel P. Berrange
On Thu, Jan 11, 2018 at 01:23:05PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Thu, Jan 11, 2018 at 01:46:38PM +0100, Max Reitz wrote: > > > On 2018-01-08 14:52, Eric Blake wrote: > > > > On 01/07/2018 06:23 AM, Richard Palethorpe wrote: > > > >>

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-01-11 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Thu, Jan 11, 2018 at 01:46:38PM +0100, Max Reitz wrote: > > On 2018-01-08 14:52, Eric Blake wrote: > > > On 01/07/2018 06:23 AM, Richard Palethorpe wrote: > > >> Add QAPI wrapper functions for the existing snapshot functionality. These > > >>

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-01-11 Thread Daniel P. Berrange
On Thu, Jan 11, 2018 at 01:46:38PM +0100, Max Reitz wrote: > On 2018-01-08 14:52, Eric Blake wrote: > > On 01/07/2018 06:23 AM, Richard Palethorpe wrote: > >> Add QAPI wrapper functions for the existing snapshot functionality. These > >> functions behave the same way as the HMP savevm, loadvm and

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-01-11 Thread Max Reitz
On 2018-01-08 14:52, Eric Blake wrote: > On 01/07/2018 06:23 AM, Richard Palethorpe wrote: >> Add QAPI wrapper functions for the existing snapshot functionality. These >> functions behave the same way as the HMP savevm, loadvm and delvm >> commands. This will allow applications, such as OpenQA, to