On Tue, Sep 19, 2017 at 06:46:19PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi Fam! > > I have a question about your image locking series: > > Can you please explain, why OFD locking is enabled by default and posix > locking is not? What is wrong with posix locking, what are the problems?
POSIX locking suffers from a horribly broken design making it practically impossible to use it reliably, particularly in a threaded program. If there are two file descriptors open to the same file, closing one FD will release locks held by the other FD. See more details here: http://0pointer.de/blog/projects/locking.html Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|