Re: [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes

2018-06-19 Thread Amol Surati
On Wed, Jun 20, 2018 at 06:23:19AM +0530, Amol Surati wrote: > On Tue, Jun 19, 2018 at 05:43:52PM -0400, John Snow wrote: > > > > > > On 06/19/2018 05:26 PM, Amol Surati wrote: > > > On Tue, Jun 19, 2018 at 08:04:03PM +0530, Amol Surati wrote: > > >> On Tue, Jun 19, 2018 at 09:45:15AM -0400,

Re: [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes

2018-06-19 Thread Amol Surati
On Tue, Jun 19, 2018 at 05:43:52PM -0400, John Snow wrote: > > > On 06/19/2018 05:26 PM, Amol Surati wrote: > > On Tue, Jun 19, 2018 at 08:04:03PM +0530, Amol Surati wrote: > >> On Tue, Jun 19, 2018 at 09:45:15AM -0400, John Snow wrote: > >>> > >>> > >>> On 06/19/2018 04:53 AM, Kevin Wolf wrote:

Re: [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes

2018-06-19 Thread John Snow
On 06/19/2018 05:26 PM, Amol Surati wrote: > On Tue, Jun 19, 2018 at 08:04:03PM +0530, Amol Surati wrote: >> On Tue, Jun 19, 2018 at 09:45:15AM -0400, John Snow wrote: >>> >>> >>> On 06/19/2018 04:53 AM, Kevin Wolf wrote: Am 19.06.2018 um 06:01 hat Amol Surati geschrieben: > On Mon,

Re: [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes

2018-06-19 Thread Amol Surati
On Tue, Jun 19, 2018 at 08:04:03PM +0530, Amol Surati wrote: > On Tue, Jun 19, 2018 at 09:45:15AM -0400, John Snow wrote: > > > > > > On 06/19/2018 04:53 AM, Kevin Wolf wrote: > > > Am 19.06.2018 um 06:01 hat Amol Surati geschrieben: > > >> On Mon, Jun 18, 2018 at 08:14:10PM -0400, John Snow

Re: [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes

2018-06-19 Thread Amol Surati
On Tue, Jun 19, 2018 at 09:45:15AM -0400, John Snow wrote: > > > On 06/19/2018 04:53 AM, Kevin Wolf wrote: > > Am 19.06.2018 um 06:01 hat Amol Surati geschrieben: > >> On Mon, Jun 18, 2018 at 08:14:10PM -0400, John Snow wrote: > >>> > >>> > >>> On 06/18/2018 02:02 PM, Amol Surati wrote: >

Re: [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes

2018-06-19 Thread John Snow
On 06/19/2018 04:53 AM, Kevin Wolf wrote: > Am 19.06.2018 um 06:01 hat Amol Surati geschrieben: >> On Mon, Jun 18, 2018 at 08:14:10PM -0400, John Snow wrote: >>> >>> >>> On 06/18/2018 02:02 PM, Amol Surati wrote: On Mon, Jun 18, 2018 at 12:05:15AM +0530, Amol Surati wrote: > This patch

Re: [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes

2018-06-19 Thread Kevin Wolf
Am 19.06.2018 um 06:01 hat Amol Surati geschrieben: > On Mon, Jun 18, 2018 at 08:14:10PM -0400, John Snow wrote: > > > > > > On 06/18/2018 02:02 PM, Amol Surati wrote: > > > On Mon, Jun 18, 2018 at 12:05:15AM +0530, Amol Surati wrote: > > >> This patch fixes the assumption that io_buffer_size is

Re: [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes

2018-06-18 Thread Amol Surati
On Mon, Jun 18, 2018 at 08:14:10PM -0400, John Snow wrote: > > > On 06/18/2018 02:02 PM, Amol Surati wrote: > > On Mon, Jun 18, 2018 at 12:05:15AM +0530, Amol Surati wrote: > >> This patch fixes the assumption that io_buffer_size is always a perfect > >> multiple of the sector size. The

Re: [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes

2018-06-18 Thread John Snow
On 06/18/2018 02:02 PM, Amol Surati wrote: > On Mon, Jun 18, 2018 at 12:05:15AM +0530, Amol Surati wrote: >> This patch fixes the assumption that io_buffer_size is always a perfect >> multiple of the sector size. The assumption is the cause of the firing >> of 'assert(n * 512 == s->sg.size);'.

Re: [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes

2018-06-18 Thread Amol Surati
On Mon, Jun 18, 2018 at 12:05:15AM +0530, Amol Surati wrote: > This patch fixes the assumption that io_buffer_size is always a perfect > multiple of the sector size. The assumption is the cause of the firing > of 'assert(n * 512 == s->sg.size);'. > > Signed-off-by: Amol Surati > --- The

Re: [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes

2018-06-18 Thread Amol Surati
On Mon, Jun 18, 2018 at 02:13:52PM -0400, John Snow wrote: > > On 06/18/2018 02:02 PM, Amol Surati wrote: > > On Mon, Jun 18, 2018 at 12:05:15AM +0530, Amol Surati wrote: > >> This patch fixes the assumption that io_buffer_size is always a perfect > >> multiple of the sector size. The assumption

Re: [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes

2018-06-18 Thread John Snow
On 06/18/2018 02:02 PM, Amol Surati wrote: > On Mon, Jun 18, 2018 at 12:05:15AM +0530, Amol Surati wrote: >> This patch fixes the assumption that io_buffer_size is always a perfect >> multiple of the sector size. The assumption is the cause of the firing >> of 'assert(n * 512 == s->sg.size);'.

[Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes

2018-06-17 Thread Amol Surati
This patch fixes the assumption that io_buffer_size is always a perfect multiple of the sector size. The assumption is the cause of the firing of 'assert(n * 512 == s->sg.size);'. Signed-off-by: Amol Surati --- hw/ide/core.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-)