Re: [Qemu-block] [RFC PATCH 6/8] quorum: Avoid bdrv_aio_writev() for rewrites

On Fri 18 Nov 2016 01:21:12 PM CET, Kevin Wolf wrote: >> > +/* one less rewrite to do */ >> > +acb->rewrite_count--; >> > +qemu_coroutine_enter_if_inactive(acb->co); >> >> I think you should only enter acb->co when acb->rewrite_count reaches >> zero. >> >> In all other cases the main

Re: [Qemu-block] [RFC PATCH 6/8] quorum: Avoid bdrv_aio_writev() for rewrites

Am 17.11.2016 um 15:54 hat Alberto Garcia geschrieben: > On Thu 10 Nov 2016 06:19:07 PM CET, Kevin Wolf wrote: > > +static void quorum_rewrite_entry(void *opaque) > > +{ > > +QuorumCo *co = opaque; > > +QuorumAIOCB *acb = co->acb; > > +BDRVQuorumState *s = acb->bs->opaque; > > +int

Re: [Qemu-block] [RFC PATCH 6/8] quorum: Avoid bdrv_aio_writev() for rewrites

On Thu 10 Nov 2016 06:19:07 PM CET, Kevin Wolf wrote: > Replacing it with bdrv_co_pwritev() prepares us for byte granularity > requests and gets us rid of the last bdrv_aio_*() user in quorum. > > Signed-off-by: Kevin Wolf > --- > block/quorum.c | 52

[Qemu-block] [RFC PATCH 6/8] quorum: Avoid bdrv_aio_writev() for rewrites

Replacing it with bdrv_co_pwritev() prepares us for byte granularity requests and gets us rid of the last bdrv_aio_*() user in quorum. Signed-off-by: Kevin Wolf --- block/quorum.c | 52 +--- 1 file changed, 33 insertions(+), 19