Re: [RFC PATCH 06/18] qemu-storage-daemon: Add --nbd-server option

2019-11-08 Thread Markus Armbruster
Max Reitz writes: > On 17.10.19 15:01, Kevin Wolf wrote: >> Add a --nbd-server option to qemu-storage-daemon to start the built-in >> NBD server right away. It maps the arguments for nbd-server-start to the >> command line. > > Well, it doesn’t quite, because nbd-server-start takes a >

Re: [RFC PATCH 06/18] qemu-storage-daemon: Add --nbd-server option

2019-11-07 Thread Eric Blake
On 11/7/19 9:27 AM, Kevin Wolf wrote: Am 07.11.2019 um 14:45 hat Eric Blake geschrieben: On 11/7/19 2:33 AM, Kevin Wolf wrote: As a replacement nbd-server-add, I envisioned adding something like a block-export-add, which would work the way that --export already does. It would also come with

Re: [RFC PATCH 06/18] qemu-storage-daemon: Add --nbd-server option

2019-11-07 Thread Kevin Wolf
Am 07.11.2019 um 14:45 hat Eric Blake geschrieben: > On 11/7/19 2:33 AM, Kevin Wolf wrote: > > As a replacement nbd-server-add, I envisioned adding something like a > > block-export-add, which would work the way that --export already does. > > It would also come with query-block-exports and

Re: [RFC PATCH 06/18] qemu-storage-daemon: Add --nbd-server option

2019-11-07 Thread Eric Blake
On 11/7/19 2:33 AM, Kevin Wolf wrote: As a replacement nbd-server-add, I envisioned adding something like a block-export-add, which would work the way that --export already does. It would also come with query-block-exports and block-export-del, and it wouldn't contain only NBD devices, but

Re: [RFC PATCH 06/18] qemu-storage-daemon: Add --nbd-server option

2019-11-06 Thread Eric Blake
On 11/6/19 6:51 AM, Max Reitz wrote: On 17.10.19 15:01, Kevin Wolf wrote: Add a --nbd-server option to qemu-storage-daemon to start the built-in NBD server right away. It maps the arguments for nbd-server-start to the command line. Well, it doesn’t quite, because nbd-server-start takes a

Re: [RFC PATCH 06/18] qemu-storage-daemon: Add --nbd-server option

2019-11-06 Thread Max Reitz
On 17.10.19 15:01, Kevin Wolf wrote: > Add a --nbd-server option to qemu-storage-daemon to start the built-in > NBD server right away. It maps the arguments for nbd-server-start to the > command line. Well, it doesn’t quite, because nbd-server-start takes a SocketAddressLegacy, and this takes a

[RFC PATCH 06/18] qemu-storage-daemon: Add --nbd-server option

2019-10-17 Thread Kevin Wolf
Add a --nbd-server option to qemu-storage-daemon to start the built-in NBD server right away. It maps the arguments for nbd-server-start to the command line. Example (only with required options): --nbd-server addr.type=inet,addr.host=localhost,addr.port=10809 Signed-off-by: Kevin Wolf ---