Re: ImageInfo oddities regarding compression

On Fri, Nov 27, 2020 at 05:52:09PM +0100, Markus Armbruster wrote: > Kevin Wolf writes: > > > Am 27.11.2020 um 13:21 hat Markus Armbruster geschrieben: > >> >> I fell down this (thankfully shallow) rabbit hole because we also have > >> >> > >> >> { 'enum': 'MultiFDCompression', > >> >>

Re: ImageInfo oddities regarding compression

On 11/27/20 4:32 AM, Kevin Wolf wrote: >>>## >>># @Qcow2CompressionType: >>># >>># Compression type used in qcow2 image file >>># >>># @zlib: zlib compression, see >>># @zstd: zstd compression, see >>># >>>#

Re: ImageInfo oddities regarding compression

Kevin Wolf writes: > Am 27.11.2020 um 13:21 hat Markus Armbruster geschrieben: >> >> I fell down this (thankfully shallow) rabbit hole because we also have >> >> >> >> { 'enum': 'MultiFDCompression', >> >> 'data': [ 'none', 'zlib', >> >> { 'name': 'zstd', 'if':

Re: ImageInfo oddities regarding compression

Am 27.11.2020 um 13:21 hat Markus Armbruster geschrieben: > >> I fell down this (thankfully shallow) rabbit hole because we also have > >> > >> { 'enum': 'MultiFDCompression', > >> 'data': [ 'none', 'zlib', > >> { 'name': 'zstd', 'if': 'defined(CONFIG_ZSTD)' } ] } > >>

Re: ImageInfo oddities regarding compression

Kevin Wolf writes: > Am 27.11.2020 um 11:14 hat Daniel P. Berrangé geschrieben: >> On Fri, Nov 27, 2020 at 11:06:36AM +0100, Markus Armbruster wrote: >> > ImageInfo has an optional member @compressed: >> > >> > ## >> > # @ImageInfo: >> > [...] >> > # @compressed: true if the

Re: ImageInfo oddities regarding compression

Am 27.11.2020 um 11:14 hat Daniel P. Berrangé geschrieben: > On Fri, Nov 27, 2020 at 11:06:36AM +0100, Markus Armbruster wrote: > > ImageInfo has an optional member @compressed: > > > > ## > > # @ImageInfo: > > [...] > > # @compressed: true if the image is compressed (Since 1.7)

Re: ImageInfo oddities regarding compression

On Fri, Nov 27, 2020 at 11:06:36AM +0100, Markus Armbruster wrote: > ImageInfo has an optional member @compressed: > > ## > # @ImageInfo: > [...] > # @compressed: true if the image is compressed (Since 1.7) > > Doc bug: neglects to specify the default. I guess it's false. > >

ImageInfo oddities regarding compression

ImageInfo has an optional member @compressed: ## # @ImageInfo: [...] # @compressed: true if the image is compressed (Since 1.7) Doc bug: neglects to specify the default. I guess it's false. The only user appears to be vmdk_get_extent_info(). Goes back to v1.7.0's commits