Re: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2021-02-07 Thread Dmitry Fomichev
On Fri, 2021-02-05 at 11:39 +0100, Klaus Jensen wrote: > On Feb 5 11:10, i...@dantalion.nl wrote: > > Hello, > > > > Thanks for this, I got everything working including the new device types > > (nvme-ns, nvme-subsys). I think I have found a small bug and do not know > > where to report this. > >

Re: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2021-02-05 Thread Keith Busch
On Sat, Feb 06, 2021 at 01:48:29AM +0900, Minwoo Im wrote: > Not sure if this is okay just give ctrl->tagset for the head > request_queue, but this patch works fine as far. Huh, that's probably not supposed to work: bio-based drivers should never use tagsets. Since this is getting a little more

Re: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2021-02-05 Thread Minwoo Im
On 21-02-06 01:43:18, Minwoo Im wrote: > On 21-02-05 08:22:52, Keith Busch wrote: > > On Sat, Feb 06, 2021 at 01:07:57AM +0900, Minwoo Im wrote: > > > If multipath is enabled, the namespace head and hidden namespace will be > > > created. In this case, /sys/block/nvme0n1/queue/nr_zones are not >

Re: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2021-02-05 Thread Minwoo Im
On 21-02-05 08:22:52, Keith Busch wrote: > On Sat, Feb 06, 2021 at 01:07:57AM +0900, Minwoo Im wrote: > > If multipath is enabled, the namespace head and hidden namespace will be > > created. In this case, /sys/block/nvme0n1/queue/nr_zones are not > > returning proper value for the namespace

Re: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2021-02-05 Thread Keith Busch
On Sat, Feb 06, 2021 at 01:07:57AM +0900, Minwoo Im wrote: > If multipath is enabled, the namespace head and hidden namespace will be > created. In this case, /sys/block/nvme0n1/queue/nr_zones are not > returning proper value for the namespace itself. By the way, the hidden > namespace

Re: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2021-02-05 Thread Keith Busch
On Sat, Feb 06, 2021 at 01:07:57AM +0900, Minwoo Im wrote: > On 21-02-05 08:02:10, Keith Busch wrote: > > On Fri, Feb 05, 2021 at 09:33:54PM +0900, Minwoo Im wrote: > > > On 21-02-05 12:42:30, Klaus Jensen wrote: > > > > On Feb 5 12:25, i...@dantalion.nl wrote: > > > > > On 05-02-2021 11:39,

Re: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2021-02-05 Thread Minwoo Im
On 21-02-05 08:02:10, Keith Busch wrote: > On Fri, Feb 05, 2021 at 09:33:54PM +0900, Minwoo Im wrote: > > On 21-02-05 12:42:30, Klaus Jensen wrote: > > > On Feb 5 12:25, i...@dantalion.nl wrote: > > > > On 05-02-2021 11:39, Klaus Jensen wrote: > > > > > This is a good way to report it ;) > > > >

Re: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2021-02-05 Thread Keith Busch
On Fri, Feb 05, 2021 at 09:33:54PM +0900, Minwoo Im wrote: > On 21-02-05 12:42:30, Klaus Jensen wrote: > > On Feb 5 12:25, i...@dantalion.nl wrote: > > > On 05-02-2021 11:39, Klaus Jensen wrote: > > > > This is a good way to report it ;) > > > > It is super helpful and super appreciated! Thanks!

Re: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2021-02-05 Thread Minwoo Im
On 21-02-05 12:42:30, Klaus Jensen wrote: > On Feb 5 12:25, i...@dantalion.nl wrote: > > On 05-02-2021 11:39, Klaus Jensen wrote: > > > This is a good way to report it ;) > > > It is super helpful and super appreciated! Thanks! > > > > Good to know :) > > > > > I cant reproduce that. Can you

Re: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2021-02-05 Thread Klaus Jensen
On Feb 5 12:25, i...@dantalion.nl wrote: > On 05-02-2021 11:39, Klaus Jensen wrote: > > This is a good way to report it ;) > > It is super helpful and super appreciated! Thanks! > > Good to know :) > > > I cant reproduce that. Can you share your qemu configuration, kernel > > version? > > I

Re: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2021-02-05 Thread i...@dantalion.nl
On 05-02-2021 11:39, Klaus Jensen wrote: > This is a good way to report it ;) > It is super helpful and super appreciated! Thanks! Good to know :) > I cant reproduce that. Can you share your qemu configuration, kernel > version? I create the image and launch QEMU with: qemu-img create -f raw

Re: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2021-02-05 Thread Klaus Jensen
On Feb 5 11:10, i...@dantalion.nl wrote: > Hello, > > Thanks for this, I got everything working including the new device types > (nvme-ns, nvme-subsys). I think I have found a small bug and do not know > where to report this. > This is a good way to report it ;) > The values for nvme device

Re: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2021-02-05 Thread i...@dantalion.nl
Hello, Thanks for this, I got everything working including the new device types (nvme-ns, nvme-subsys). I think I have found a small bug and do not know where to report this. The values for nvme device property zoned.append_size_limit are not sanity checked, you can set it to invalid values such

Re: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2021-02-04 Thread Klaus Jensen
On Feb 4 14:32, i...@dantalion.nl wrote: > Hello Dmitry, > > I tried to apply your patches to nvme-next with > <20201104102248.32168-1-...@irrelevant.dk> as base but get quite a few > 'does not apply errors'. > > Can you confirm that nvme-next is: > git://git.infradead.org/qemu-nvme.git > >

Re: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2021-01-07 Thread Klaus Jensen
On Dec 9 10:57, Klaus Jensen wrote: > Hi Dmitry, > > By and large, this looks OK to me. There are still some issues here and > there, and some comments of mine that you did not address, but I will > follow up with patches to fix that. Let's get this merged. > > It looks like the nvme-next you

Re: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2020-12-15 Thread Keith Busch
Hi Dmitry, Looks good to me, thanks for sticking with it. Reviewed-by: Keith Busch

Re: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2020-12-10 Thread Klaus Jensen
Max Reitz ; > > Maxim Levitsky ; Fam Zheng ; > > Niklas Cassel ; Damien Le Moal > > ; qemu-block@nongnu.org; qemu- > > de...@nongnu.org; Alistair Francis ; Matias > > Bjorling > > Subject: Re: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types > > and Zoned

RE: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2020-12-10 Thread Dmitry Fomichev
l > ; qemu-block@nongnu.org; qemu- > de...@nongnu.org; Alistair Francis ; Matias > Bjorling > Subject: Re: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types > and Zoned Namespace Command Set > > Hi Dmitry, > > By and large, this looks OK to me. There are still s

Re: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2020-12-09 Thread Klaus Jensen
Hi Dmitry, By and large, this looks OK to me. There are still some issues here and there, and some comments of mine that you did not address, but I will follow up with patches to fix that. Let's get this merged. It looks like the nvme-next you rebased on is slightly old and missing two commits: