RE: [PATCH v7 05/11] hw/block/nvme: Support Zoned Namespace Command Set

2020-10-21 Thread Dmitry Fomichev
qemu-block@nongnu.org; qemu-de...@nongnu.org; Alistair Francis > ; Matias Bjorling > Subject: Re: [PATCH v7 05/11] hw/block/nvme: Support Zoned Namespace > Command Set > > On Oct 19 11:17, Dmitry Fomichev wrote: > > +/* > > + * Close or finish all the zones that are curr

Re: [PATCH v7 05/11] hw/block/nvme: Support Zoned Namespace Command Set

2020-10-21 Thread Klaus Jensen
On Oct 19 11:17, Dmitry Fomichev wrote: > +/* > + * Close or finish all the zones that are currently open. > + */ > +static void nvme_zoned_clear_ns(NvmeNamespace *ns) > +{ > +NvmeZone *zone; > +uint32_t set_state; > +int i; > + > +zone = ns->zone_array; > +for (i = 0; i <

Re: [PATCH v7 05/11] hw/block/nvme: Support Zoned Namespace Command Set

2020-10-20 Thread Klaus Jensen
On Oct 19 11:17, Dmitry Fomichev wrote: > diff --git a/hw/block/nvme-ns.c b/hw/block/nvme-ns.c > index 974aea33f7..fedfad595c 100644 > --- a/hw/block/nvme-ns.c > +++ b/hw/block/nvme-ns.c > @@ -133,6 +320,12 @@ static Property nvme_ns_props[] = { > DEFINE_PROP_UINT32("nsid", NvmeNamespace,

Re: [PATCH v7 05/11] hw/block/nvme: Support Zoned Namespace Command Set

2020-10-19 Thread Klaus Jensen
On Oct 19 11:50, Klaus Jensen wrote: > On Oct 19 11:17, Dmitry Fomichev wrote: > > +static bool nvme_finalize_zoned_write(NvmeNamespace *ns, NvmeRequest *req, > > + bool failed) > > +{ > > +NvmeRwCmd *rw = (NvmeRwCmd *)>cmd; > > +NvmeZone *zone; > > +

Re: [PATCH v7 05/11] hw/block/nvme: Support Zoned Namespace Command Set

2020-10-19 Thread Klaus Jensen
On Oct 19 11:17, Dmitry Fomichev wrote: > diff --git a/hw/block/nvme-ns.h b/hw/block/nvme-ns.h > index d6b2808b97..170cbb8cdc 100644 > --- a/hw/block/nvme-ns.h > +++ b/hw/block/nvme-ns.h > @@ -34,6 +45,18 @@ typedef struct NvmeNamespace { > const uint32_t *iocs; > uint8_t csi; > >

Re: [PATCH v7 05/11] hw/block/nvme: Support Zoned Namespace Command Set

2020-10-19 Thread Klaus Jensen
On Oct 19 11:17, Dmitry Fomichev wrote: > The emulation code has been changed to advertise NVM Command Set when > "zoned" device property is not set (default) and Zoned Namespace > Command Set otherwise. > > Define values and structures that are needed to support Zoned > Namespace Command Set