Re: [PATCH v2 01/23] iotests: Introduce $SOCK_DIR

2019-10-18 Thread Eric Blake
On 10/18/19 4:03 AM, Max Reitz wrote:   -if [ ! -e "$TEST_DIR" ]; then -    mkdir "$TEST_DIR" +tmp_sock_dir=false +if [ -z "$SOCK_DIR" ]; then +    SOCK_DIR=$(mktemp -d) +    tmp_sock_dir=true   fi +mkdir -p "$SOCK_DIR" || _init_error 'Failed to create SOCK_DIR' Thinking about this

Re: [PATCH v2 01/23] iotests: Introduce $SOCK_DIR

2019-10-18 Thread Max Reitz
On 17.10.19 16:52, Eric Blake wrote: > On 10/17/19 8:31 AM, Max Reitz wrote: >> Unix sockets generally have a maximum path length.  Depending on your >> $TEST_DIR, it may be exceeded and then all tests that create and use >> Unix sockets there may fail. >> >> Circumvent this by adding a new

Re: [PATCH v2 01/23] iotests: Introduce $SOCK_DIR

2019-10-17 Thread Eric Blake
On 10/17/19 8:31 AM, Max Reitz wrote: Unix sockets generally have a maximum path length. Depending on your $TEST_DIR, it may be exceeded and then all tests that create and use Unix sockets there may fail. Circumvent this by adding a new scratch directory specifically for Unix socket files. It