Re: [PATCH v2 3/4] build: move COLO under CONFIG_REPLICATION

2023-04-28 Thread Juan Quintela
@treblig.org;hre...@redhat.com; >>> kw...@redhat.com;lizhij...@fujitsu.com >>> Subject: Re: [PATCH v2 3/4] build: move COLO under CONFIG_REPLICATION >>> >>> On 21.04.23 06:02, Zhang, Chen wrote: >>>> >>>>> -Original Message- >

Re: [PATCH v2 3/4] build: move COLO under CONFIG_REPLICATION

2023-04-27 Thread Vladimir Sementsov-Ogievskiy
...@redhat.com; Zhang, Hailiang;phi...@linaro.org; th...@redhat.com;berra...@redhat.com;marcandre.lur...@redhat.com; pbonz...@redhat.com;d...@treblig.org;hre...@redhat.com; kw...@redhat.com;lizhij...@fujitsu.com Subject: Re: [PATCH v2 3/4] build: move COLO under CONFIG_REPLICATION On 21.04.23 06:02, Zhang

RE: [PATCH v2 3/4] build: move COLO under CONFIG_REPLICATION

2023-04-22 Thread Zhang, Chen
@redhat.com; Zhang, > Hailiang ; phi...@linaro.org; > th...@redhat.com; berra...@redhat.com; marcandre.lur...@redhat.com; > pbonz...@redhat.com; d...@treblig.org; hre...@redhat.com; > kw...@redhat.com; lizhij...@fujitsu.com > Subject: Re: [PATCH v2 3/4] build: move COLO under CONFIG_REPLICAT

Re: [PATCH v2 3/4] build: move COLO under CONFIG_REPLICATION

2023-04-21 Thread Vladimir Sementsov-Ogievskiy
On 21.04.23 06:02, Zhang, Chen wrote: -Original Message- From: Vladimir Sementsov-Ogievskiy Sent: Thursday, April 20, 2023 6:53 AM To: qemu-de...@nongnu.org Cc: qemu-block@nongnu.org; michael.r...@amd.com; arm...@redhat.com; ebl...@redhat.com; jasow...@redhat.com;

RE: [PATCH v2 3/4] build: move COLO under CONFIG_REPLICATION

2023-04-20 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Thursday, April 20, 2023 6:53 AM > To: qemu-de...@nongnu.org > Cc: qemu-block@nongnu.org; michael.r...@amd.com; arm...@redhat.com; > ebl...@redhat.com; jasow...@redhat.com; quint...@redhat.com; Zhang, > Hailiang ;

Re: [PATCH v2 3/4] build: move COLO under CONFIG_REPLICATION

2023-04-20 Thread Dr. David Alan Gilbert
* Vladimir Sementsov-Ogievskiy (vsement...@yandex-team.ru) wrote: > We don't allow to use x-colo capability when replication is not > configured. So, no reason to build COLO when replication is disabled, > it's unusable in this case. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- >

Re: [PATCH v2 3/4] build: move COLO under CONFIG_REPLICATION

2023-04-20 Thread Juan Quintela
Vladimir Sementsov-Ogievskiy wrote: > On 20.04.23 13:03, Juan Quintela wrote: >> Vladimir Sementsov-Ogievskiy wrote: >>> We don't allow to use x-colo capability when replication is not >>> configured. So, no reason to build COLO when replication is disabled, >>> it's unusable in this case. >>>

Re: [PATCH v2 3/4] build: move COLO under CONFIG_REPLICATION

2023-04-20 Thread Vladimir Sementsov-Ogievskiy
On 20.04.23 13:03, Juan Quintela wrote: Vladimir Sementsov-Ogievskiy wrote: We don't allow to use x-colo capability when replication is not configured. So, no reason to build COLO when replication is disabled, it's unusable in this case. Signed-off-by: Vladimir Sementsov-Ogievskiy +bool

Re: [PATCH v2 3/4] build: move COLO under CONFIG_REPLICATION

2023-04-20 Thread Juan Quintela
Vladimir Sementsov-Ogievskiy wrote: > We don't allow to use x-colo capability when replication is not > configured. So, no reason to build COLO when replication is disabled, > it's unusable in this case. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > +bool migrate_colo_enabled(void) > +{ > +