Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

2015-06-29 Thread Laurent Vivier
On 29/06/2015 05:01, Programmingkid wrote: On Jun 28, 2015, at 8:29 PM, Laurent Vivier wrote: Hi, On 29/06/2015 01:43, Programmingkid wrote: On Jun 25, 2015, at 2:01 PM, Peter Maydell wrote: On 25 June 2015 at 18:56, Programmingkid programmingk...@gmail.com

Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

2015-06-28 Thread Programmingkid
On Jun 25, 2015, at 2:01 PM, Peter Maydell wrote: On 25 June 2015 at 18:56, Programmingkid programmingk...@gmail.com wrote: Nice to hear from you again Laurent. The only way a solution in hdev_open() would work is if it could prevent find_image_format() from executing. Otherwise

Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

2015-06-28 Thread Laurent Vivier
Hi, On 29/06/2015 01:43, Programmingkid wrote: On Jun 25, 2015, at 2:01 PM, Peter Maydell wrote: On 25 June 2015 at 18:56, Programmingkid programmingk...@gmail.com wrote: Nice to hear from you again Laurent. The only way a solution in hdev_open() would work is if it could prevent

Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

2015-06-28 Thread Programmingkid
On Jun 28, 2015, at 8:29 PM, Laurent Vivier wrote: Hi, On 29/06/2015 01:43, Programmingkid wrote: On Jun 25, 2015, at 2:01 PM, Peter Maydell wrote: On 25 June 2015 at 18:56, Programmingkid programmingk...@gmail.com wrote: Nice to hear from you again Laurent. The only way a solution

Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

2015-06-26 Thread Laurent Vivier
On 25/06/2015 19:19, Laurent Vivier wrote: On 25/06/2015 18:16, Paolo Bonzini wrote: On 25/06/2015 18:12, Laurent Vivier wrote: On 25/06/2015 17:48, Paolo Bonzini wrote: On 25/06/2015 17:32, Programmingkid wrote: I think we are going to have to agree to disagree. I have never used

Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

2015-06-26 Thread Stefan Hajnoczi
On Thu, Jun 25, 2015 at 07:19:14PM +0200, Laurent Vivier wrote: On 25/06/2015 18:16, Paolo Bonzini wrote: On 25/06/2015 18:12, Laurent Vivier wrote: On 25/06/2015 17:48, Paolo Bonzini wrote: On 25/06/2015 17:32, Programmingkid wrote: I think we are going to have to agree

Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

2015-06-25 Thread Paolo Bonzini
On 25/06/2015 20:07, Programmingkid wrote: I honestly think it is in the right place. The function find_image_format() is doing just that - trying to find the format. The image part of the function's name does bother me. But we could ignore it. Since we know it is a real cdrom drive, it

Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

2015-06-25 Thread Programmingkid
On Jun 25, 2015, at 11:14 AM, Programmingkid wrote: On Jun 25, 2015, at 2:53 AM, Markus Armbruster wrote: Programmingkid programmingk...@gmail.com writes: On Jun 23, 2015, at 2:06 PM, John Snow wrote: On 06/23/2015 01:56 PM, Programmingkid wrote: Fix real cdrom detection so that

Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

2015-06-25 Thread Programmingkid
On Jun 25, 2015, at 11:32 AM, Programmingkid wrote: On Jun 25, 2015, at 11:14 AM, Programmingkid wrote: On Jun 25, 2015, at 2:53 AM, Markus Armbruster wrote: Programmingkid programmingk...@gmail.com writes: On Jun 23, 2015, at 2:06 PM, John Snow wrote: On 06/23/2015 01:56

Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

2015-06-25 Thread Paolo Bonzini
On 25/06/2015 17:32, Programmingkid wrote: I think we are going to have to agree to disagree. I have never used the /dev/sr(0 | 1) devices and don't see how they would be effected by this patch. Are you trying to say the /dev/sr(0 | 1) devices *should* be handled by this patch? Thinking

Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

2015-06-25 Thread Laurent Vivier
On 25/06/2015 17:48, Paolo Bonzini wrote: On 25/06/2015 17:32, Programmingkid wrote: I think we are going to have to agree to disagree. I have never used the /dev/sr(0 | 1) devices and don't see how they would be effected by this patch. Are you trying to say the /dev/sr(0 | 1) devices

Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

2015-06-25 Thread Laurent Vivier
On 25/06/2015 18:16, Paolo Bonzini wrote: On 25/06/2015 18:12, Laurent Vivier wrote: On 25/06/2015 17:48, Paolo Bonzini wrote: On 25/06/2015 17:32, Programmingkid wrote: I think we are going to have to agree to disagree. I have never used the /dev/sr(0 | 1) devices and don't see how

Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

2015-06-25 Thread Paolo Bonzini
On 25/06/2015 18:12, Laurent Vivier wrote: On 25/06/2015 17:48, Paolo Bonzini wrote: On 25/06/2015 17:32, Programmingkid wrote: I think we are going to have to agree to disagree. I have never used the /dev/sr(0 | 1) devices and don't see how they would be effected by this patch. Are

Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

2015-06-25 Thread Programmingkid
On Jun 25, 2015, at 11:48 AM, Paolo Bonzini wrote: On 25/06/2015 17:32, Programmingkid wrote: I think we are going to have to agree to disagree. I have never used the /dev/sr(0 | 1) devices and don't see how they would be effected by this patch. Are you trying to say the /dev/sr(0 | 1)

Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

2015-06-25 Thread Paolo Bonzini
On 25/06/2015 19:56, Programmingkid wrote: In fact, programmingkid, you should fix it in hdev_open() where there is already a #if __APPLE__ . Nice to hear from you again Laurent. The only way a solution in hdev_open() would work is if it could prevent find_image_format() from executing.

Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

2015-06-25 Thread Programmingkid
On Jun 25, 2015, at 12:12 PM, Laurent Vivier wrote: On 25/06/2015 17:48, Paolo Bonzini wrote: On 25/06/2015 17:32, Programmingkid wrote: I think we are going to have to agree to disagree. I have never used the /dev/sr(0 | 1) devices and don't see how they would be effected by this

Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

2015-06-25 Thread Peter Maydell
On 25 June 2015 at 18:56, Programmingkid programmingk...@gmail.com wrote: Nice to hear from you again Laurent. The only way a solution in hdev_open() would work is if it could prevent find_image_format() from executing. Otherwise find_image_format() would just quit QEMU with an error. The

Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

2015-06-25 Thread Markus Armbruster
Programmingkid programmingk...@gmail.com writes: On Jun 23, 2015, at 2:06 PM, John Snow wrote: On 06/23/2015 01:56 PM, Programmingkid wrote: Fix real cdrom detection so that a real cdrom can actually be used. signed-off-by: John Arbuckle programmingk...@gmail.com