Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10] block/qapi: Remove redundat NULL check to silence Coverity

2017-07-31 Thread Philippe Mathieu-Daudé
On 07/31/2017 12:17 PM, Jeff Cody wrote: On Mon, Jul 31, 2017 at 11:54:57AM -0300, Philippe Mathieu-Daudé wrote: On 07/31/2017 11:38 AM, Jeff Cody wrote: On Mon, Jul 31, 2017 at 02:51:11PM +0200, Kevin Wolf wrote: When skipping implicit nodes in bdrv_block_device_info(), we know that bs0 is

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10] block/qapi: Remove redundat NULL check to silence Coverity

2017-07-31 Thread Jeff Cody
On Mon, Jul 31, 2017 at 11:54:57AM -0300, Philippe Mathieu-Daudé wrote: > On 07/31/2017 11:38 AM, Jeff Cody wrote: > >On Mon, Jul 31, 2017 at 02:51:11PM +0200, Kevin Wolf wrote: > >>When skipping implicit nodes in bdrv_block_device_info(), we know that > >>bs0 is always non-NULL; initially,

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10] block/qapi: Remove redundat NULL check to silence Coverity

2017-07-31 Thread Kevin Wolf
Am 31.07.2017 um 16:54 hat Philippe Mathieu-Daudé geschrieben: > On 07/31/2017 11:38 AM, Jeff Cody wrote: > > On Mon, Jul 31, 2017 at 02:51:11PM +0200, Kevin Wolf wrote: > > > When skipping implicit nodes in bdrv_block_device_info(), we know that > > > bs0 is always non-NULL; initially, because

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10] block/qapi: Remove redundat NULL check to silence Coverity

2017-07-31 Thread Philippe Mathieu-Daudé
On 07/31/2017 11:38 AM, Jeff Cody wrote: On Mon, Jul 31, 2017 at 02:51:11PM +0200, Kevin Wolf wrote: When skipping implicit nodes in bdrv_block_device_info(), we know that bs0 is always non-NULL; initially, because it's taken from a BdrvChild Not to mention, we deference bs0 in the chunk of

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10] block/qapi: Remove redundat NULL check to silence Coverity

2017-07-31 Thread Jeff Cody
On Mon, Jul 31, 2017 at 02:51:11PM +0200, Kevin Wolf wrote: > When skipping implicit nodes in bdrv_block_device_info(), we know that > bs0 is always non-NULL; initially, because it's taken from a BdrvChild Not to mention, we deference bs0 in the chunk of code right above this, so we'd segfault

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10] block/qapi: Remove redundat NULL check to silence Coverity

2017-07-31 Thread Kevin Wolf
Am 31.07.2017 um 16:00 hat Eric Blake geschrieben: > On 07/31/2017 08:06 AM, Eric Blake wrote: > > On 07/31/2017 07:51 AM, Kevin Wolf wrote: > > In the subject line, s/redundat/redundant/ Thanks, I'll fix this. Kevin signature.asc Description: PGP signature

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10] block/qapi: Remove redundat NULL check to silence Coverity

2017-07-31 Thread Eric Blake
On 07/31/2017 08:06 AM, Eric Blake wrote: > On 07/31/2017 07:51 AM, Kevin Wolf wrote: In the subject line, s/redundat/redundant/ >> When skipping implicit nodes in bdrv_block_device_info(), we know that >> bs0 is always non-NULL; initially, because it's taken from a BdrvChild >> and a BdrvChild

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10] block/qapi: Remove redundat NULL check to silence Coverity

2017-07-31 Thread Eric Blake
On 07/31/2017 07:51 AM, Kevin Wolf wrote: > When skipping implicit nodes in bdrv_block_device_info(), we know that > bs0 is always non-NULL; initially, because it's taken from a BdrvChild > and a BdrvChild never has a NULL bs, and after the first iteration > because implicit nodes always have a