Re: [Qemu-block] [Qemu-devel] [PATCH v3 2/3] blkdebug: Extend rule check for additional types

2018-11-13 Thread John Snow
On 11/13/18 6:34 PM, Marc Olson wrote: > On 11/13/18 3:22 PM, John Snow wrote: >> >> On 11/12/18 2:06 AM, Marc Olson via Qemu-devel wrote: >>> Break out the more common parts of the BlkdebugRule struct, and make >>> rule_check() more explicit about operating only on error injection types >>> so

Re: [Qemu-block] [Qemu-devel] [PATCH v3 2/3] blkdebug: Extend rule check for additional types

2018-11-13 Thread Marc Olson
On 11/13/18 3:22 PM, John Snow wrote: On 11/12/18 2:06 AM, Marc Olson via Qemu-devel wrote: Break out the more common parts of the BlkdebugRule struct, and make rule_check() more explicit about operating only on error injection types so that additional rule types can be added in the future.

Re: [Qemu-block] [Qemu-devel] [PATCH v3 2/3] blkdebug: Extend rule check for additional types

2018-11-13 Thread John Snow
On 11/12/18 2:06 AM, Marc Olson via Qemu-devel wrote: > Break out the more common parts of the BlkdebugRule struct, and make > rule_check() more explicit about operating only on error injection types > so that additional rule types can be added in the future. > > Signed-off-by: Marc Olson >